Re: [kvm-unit-tests PATCH v4 7/9] s390x: css: msch, enable test

Pierre Morel
2019-12-13T14:40:50Z

On 2019-12-13 10:33, Cornelia Huck wrote:
> On Thu, 12 Dec 2019 18:33:15 +0100
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> After all, I make it simple by testing if the MSCH works as expected, no
>> retry, no delay.
>> This is just a test.
>
> That's probably fine if you only run under kvm (not sure what your
> further plans here are).

If the test fails, it fails.

However, for other tests we need the enable to work.
For example before making a SENSE_ID, in this case we will make retries.

>
>>
>> I will add a new patch to add a library function to enable the channel,
>> with retry to serve when we really need to enable the channel, not to test.
>
> A simple enable should be enough for kvm-only usage, we can add a retry
> easily if needed.
>
> We probably can also defer adding the library function until after we
> get another user :)
>

I already work on it in the prepared next series, I have
- the enable test
and
- a enable_sch to use as a librairy function

Regards,
Pierre

--
Pierre Morel
IBM Lab Boeblingen