Re: [kvm-unit-tests PATCH v4 8/9] s390x: css: ssch/tsch with sense and interrupt

Pierre Morel
2019-12-12T18:20:15Z

On 2019-12-12 15:10, Pierre Morel wrote:
>
>
> On 2019-12-12 13:26, Cornelia Huck wrote:
>> On Wed, 11 Dec 2019 16:46:09 +0100
>> Pierre Morel <pmorel@linux.ibm.com> wrote:
>>

...

>
>>
>> Also, doesn't the interrupt handler check for the intparm already?
>
> Yes, if the interrupt fires.
>
>>
>>> +
>>> +    senseid.cu_type = buffer[2] | (buffer[1] << 8);
>>
>> This still looks odd; why not have the ccw fill out the senseid
>> structure directly?
>
> Oh sorry, you already said and I forgot to modify this.
> thanks

hum, sorry, I forgot, the sense structure is not padded so I need this.

Regards,
Pierre

--
Pierre Morel
IBM Lab Boeblingen