Re: [kvm-unit-tests PATCH v3 1/9] s390x: smp: Cleanup smp.c

David Hildenbrand
2020-01-20T12:02:42Z

On 17.01.20 11:46, Janosch Frank wrote:
> Let's remove a lot of badly formatted code by introducing the
> wait_for_flag() function.
>
> Also let's remove some stray spaces.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
> s390x/smp.c | 42 +++++++++++++++++++++++-------------------
> 1 file changed, 23 insertions(+), 19 deletions(-)
>
> diff --git a/s390x/smp.c b/s390x/smp.c
> index ab7e46c..8d8e3a5 100644
> --- a/s390x/smp.c
> +++ b/s390x/smp.c
> @@ -22,6 +22,13 @@
>
> static int testflag = 0;
>
> +static void wait_for_flag(void)
> +{
> + while (!testflag) {
> + mb();
> + }

No need for the {}

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb