From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com ([207.211.31.81]:21402 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726873AbgA3L3L (ORCPT ); Thu, 30 Jan 2020 06:29:11 -0500 Date: Thu, 30 Jan 2020 12:28:49 +0100 From: Cornelia Huck Subject: Re: [PATCH v8 4/4] selftests: KVM: testing the local IRQs resets Message-ID: <20200130122849.763bd678.cohuck@redhat.com> In-Reply-To: References: <20200129200312.3200-1-frankja@linux.ibm.com> <20200129200312.3200-5-frankja@linux.ibm.com> <20200130115543.1f06a840.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/IJGqp2CXGXJEd7ft5PTSr5h"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-s390-owner@vger.kernel.org List-ID: To: Janosch Frank Cc: kvm@vger.kernel.org, thuth@redhat.com, borntraeger@de.ibm.com, david@redhat.com, linux-s390@vger.kernel.org --Sig_/IJGqp2CXGXJEd7ft5PTSr5h Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 30 Jan 2020 12:18:31 +0100 Janosch Frank wrote: > On 1/30/20 11:55 AM, Cornelia Huck wrote: > > On Wed, 29 Jan 2020 15:03:12 -0500 > > Janosch Frank wrote: > >> +=09irq_state.len =3D sizeof(buf); > >> +=09irq_state.buf =3D (unsigned long)buf; > >> +=09irqs =3D _vcpu_ioctl(vm, VCPU_ID, KVM_S390_GET_IRQ_STATE, &irq_sta= te); > >> +=09/* > >> +=09 * irqs contains the number of retrieved interrupts, apart from th= e > >> +=09 * emergency call that should be cleared by the resets, there shou= ld be > >> +=09 * none. =20 > >=20 > > Even if there were any, they should have been cleared by the reset, > > right? =20 >=20 > Yes, that's what "there should be none" should actually express. > I added the comment before sending out. So what about /* * irqs contains the number of retrieved interrupts. Any interrupt * (notably, the emergency call interrupt we have injected) should * be cleared by the resets, so this should be 0. */ ? >=20 > > =20 > >> +=09 */ > >> +=09if (irqs < 0) > >> +=09=09printf("Error by getting IRQ: errno %d\n", errno); =20 > >=20 > > "Error getting pending IRQs" ? =20 >=20 > "Could not fetch IRQs: errno %d\n" ? Sounds good. >=20 > > =20 > >> + > >> +=09TEST_ASSERT(!irqs, "IRQ pending"); > >> +} --Sig_/IJGqp2CXGXJEd7ft5PTSr5h Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw9DWbcNiT/aowBjO3s9rk8bwL68FAl4yvfIACgkQ3s9rk8bw L68r3w//YBTijJZDcW9Iv0bPJd4yvD8TBHAh/e5eGYr3w6OLSz3iPe8o8R8dQ4eh PBItGlSaFoCqXTFxi/D0Pmr0ZaS5jH9hwJTHNAN8rJiLGhZY0vOw5hVFhffck+u+ twM/Qq/oDJL/lMUVAAj1hHGb4Dvh1ExIixKkDAnHlcYTHatYmE1VPrc7OvV1VmxG hdN+faSQEtZerhME/ujhgoz+VAP2JXOKbsp/+0nvW4twofrBYyRK4iyBWpJHOR9Z XjiIbG0fflXi59vQ0Bm8l/Hoj7rzWRtcKdLQPgY1wbaoVzC0IHTg2esrucJis6Pv musi9mRoDEFOZD5jhS069KcG6n10RKAIrf5Ap4NHQLneK0oLE7rJOFLiv+PFTNi3 /uVBik0MB8NI9qSiLR4bfEjWJ9dWTOQbPpsd1WcIWJ20TbX3AMo6DFYiM+2xsA16 4J6VvRV8N1hRIYzLwYn9UvAU5mp0c+racy6rWnqOv8SMWCxe0ZvWtFodLiiAopK+ SGHhcXagxEkTXQkCRMwFSJdli31IWAVji6p89yp32zk1nzZsxbFcvNp8jrywmGJN GZxmjSaLk3cvG2bHvw5ZRyWuBC+5uEm6u/vc8rKSW/AhykenxiF56KttS72a5w4E 0Fv/TSjyM9kfQdR379VO937UiW5SxuPK2j+9XGcfHxshWLd4/yQ= =ovR4 -----END PGP SIGNATURE----- --Sig_/IJGqp2CXGXJEd7ft5PTSr5h--