Re: [PATCH v3 10/37] KVM: s390: protvirt: Add KVM api documentation

Christian Borntraeger
2020-02-20T13:57:06Z

On 20.02.20 14:05, David Hildenbrand wrote:
> On 20.02.20 11:39, Christian Borntraeger wrote:
>> From: Janosch Frank <frankja@linux.ibm.com>
>>
>> Add documentation for KVM_CAP_S390_PROTECTED capability and the
>> KVM_S390_PV_COMMAND and KVM_S390_PV_COMMAND_VCPU ioctls.
>
> Outdated.

ACK.

>
> I suggest moving this after "[PATCH v3 37/37] KVM: s390: protvirt:
> introduce and enable KVM_CAP_S390_PROTECTED" or even squashing it into
> that one.

Will move at the end.

[...]

>> +8.23 KVM_CAP_S390_PROTECTED
>> +
>> +Architecture: s390
>> +
>> +This capability indicates that KVM can start protected VMs and the
>> +Ultravisor has therefore been initialized.
>>
>
> Maybe document that KVM_S390_PV_COMMAND and the new MP is available.
> Also maybe that MP commands can now fail.

diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
index faca9977cbe7..7faf32b92d8c 100644
--- a/Documentation/virt/kvm/api.rst
+++ b/Documentation/virt/kvm/api.rst
@@ -6081,3 +6081,6 @@ Architecture: s390

This capability indicates that KVM can start protected VMs and the
Ultravisor has therefore been initialized.
+This will provide the new KVM_S390_PV_COMMAND ioctl and it will allow
+KVM_MP_STATE_LOAD as new MP_STATE. KVM_SET_MP_STATE can now fail for
+protected guests when the state change is invalid.