Re: [PATCH -v2] treewide: Rename "unencrypted" to "decrypted"

Robin Murphy
2020-03-19T11:06:32Z

[since this is in my inbox...]

On 2020-03-19 10:28 am, Borislav Petkov wrote:
> On Thu, Mar 19, 2020 at 11:20:11AM +0100, Christoph Hellwig wrote:
>> I thought we agreed that decrypted is absolutely the wrong term.
>
> I don't think we did. At least I don't know where we did that.
>
>> So NAK - if you want to change things it needs to go the other way.
>
> We are already using "decrypted" everywhere in arch/x86/. Changing that
> would be a *lot* more churn.
>
> And it is just a term, for chrissakes, to denote memory which is not
> encrypted. And it would make our lifes easier if we had only *two* terms
> instead of three or more. Especially if the concept we denote with this
> is a binary one: encrypted memory and *not* encrypted memory.

Let me add another vote from a native English speaker that "unencrypted"
is the appropriate term to imply the *absence* of encryption, whereas
"decrypted" implies the *reversal* of applied encryption.

Naming things is famously hard, for good reason - names are *important*
for understanding. Just because a decision was already made one way
doesn't mean that that decision was necessarily right. Churning one area
to be consistently inaccurate just because it's less work than churning
another area to be consistently accurate isn't really the best excuse.

Robin.