From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com ([207.211.31.81]:22022 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726177AbgDJTeZ (ORCPT ); Fri, 10 Apr 2020 15:34:25 -0400 Received: by mail-qt1-f197.google.com with SMTP id j7so2672238qtd.22 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Mina Almasry , Andrew Morton On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > unsigned long i; > > if (size_to_hstate(PAGE_SIZE << order)) { > - pr_warn("hugepagesz= specified twice, ignoring\n"); > return; > } Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu -- Peter Xu