Re: [PATCH] vfio-ccw: make vfio_ccw_regops variables declarations static

Cornelia Huck
2020-06-04T11:27:29Z

On Thu, 4 Jun 2020 13:20:45 +0200
Vasily Gorbik <gor@linux.ibm.com> wrote:

> Fixes the following sparse warnings:
> drivers/s390/cio/vfio_ccw_chp.c:62:30: warning: symbol 'vfio_ccw_schib_region_ops' was not declared. Should it be static?
> drivers/s390/cio/vfio_ccw_chp.c:117:30: warning: symbol 'vfio_ccw_crw_region_ops' was not declared. Should it be static?
>
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_chp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_chp.c b/drivers/s390/cio/vfio_ccw_chp.c
> index 876f6ade51cc..a646fc81c872 100644
> --- a/drivers/s390/cio/vfio_ccw_chp.c
> +++ b/drivers/s390/cio/vfio_ccw_chp.c
> @@ -59,7 +59,7 @@ static void vfio_ccw_schib_region_release(struct vfio_ccw_private *private,
>
> }
>
> -const struct vfio_ccw_regops vfio_ccw_schib_region_ops = {
> +static const struct vfio_ccw_regops vfio_ccw_schib_region_ops = {
> .read = vfio_ccw_schib_region_read,
> .write = vfio_ccw_schib_region_write,
> .release = vfio_ccw_schib_region_release,
> @@ -131,7 +131,7 @@ static void vfio_ccw_crw_region_release(struct vfio_ccw_private *private,
>
> }
>
> -const struct vfio_ccw_regops vfio_ccw_crw_region_ops = {
> +static const struct vfio_ccw_regops vfio_ccw_crw_region_ops = {
> .read = vfio_ccw_crw_region_read,
> .write = vfio_ccw_crw_region_write,
> .release = vfio_ccw_crw_region_release,

Oops.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Feel free to merge this directly.