Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs

Andy Shevchenko
2020-06-05T13:25:58Z

On Tue, Jun 02, 2020 at 12:24:31PM +0200, Alexander Gordeev wrote:
> On Mon, May 18, 2020 at 01:50:59PM +0200, Alexander Gordeev wrote:
> > On Mon, May 18, 2020 at 02:33:43PM +0300, Andy Shevchenko wrote:
> > > On Mon, May 18, 2020 at 1:40 PM Alexander Gordeev
> > > <agordeev@linux.ibm.com> wrote:
> > > >
> > > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does
> > > > not take into account order of halfwords on 64-bit big
> > > > endian architectures.
> > >
> > > Thanks for report and the patch!
> > >
> > > Did it work before? Can we have a test case for that that we will see
> > > the failure?
> >
> > The test exists and enabled with CONFIG_TEST_BITMAP.
> > It does not appear ever passed before on 64 BE.
> > It does not fail on 64 LE for me either.
>
> Hi Andy et al,
>
> Any feedback on the fix? Does it work on 64 LE for you?

Test case, please.

Yes, you can simulate BE test case on LE platform and vise versa.

--
With Best Regards,
Andy Shevchenko