From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49066 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgFQH7T (ORCPT ); Wed, 17 Jun 2020 03:59:19 -0400 Date: Wed, 17 Jun 2020 09:58:31 +0200 From: Heiko Carstens Subject: Re: [v3 PATCH 2/2] printk: Make linux/printk.h self-contained Message-ID: <20200617075831.GA4479@osiris> References: <20200617071524.GA3055@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-s390-owner@vger.kernel.org List-ID: To: Herbert Xu Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linux Kernel Mailing List , Peter Zijlstra , Ingo Molnar , Will Deacon , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org On Wed, Jun 17, 2020 at 05:17:21PM +1000, Herbert Xu wrote: > As it stands if you include printk.h by itself it will fail to > compile because it requires definitions from ratelimit.h. However, > simply including ratelimit.h from printk.h does not work due to > inclusion loops involving sched.h and kernel.h. > > This patch solves this by moving bits from ratelimit.h into a new > header file which can then be included by printk.h without any > worries about header loops. > > The build bot then revealed some intriguing failures arising out > of this patch. On s390 there is an inclusion loop with asm/bug.h > and linux/kernel.h that triggers a compile failure, because kernel.h > will cause asm-generic/bug.h to be included before s390's own > asm/bug.h has finished processing. This has been fixed by not > including kernel.h in arch/s390/include/asm/bug.h. > > Signed-off-by: Herbert Xu > Reviewed-by: Andy Shevchenko > Reviewed-by: Sergey Senozhatsky > Acked-by: Petr Mladek > Acked-by: Steven Rostedt (VMware) > --- > > arch/s390/include/asm/bug.h | 2 - FWIW, feel free to add Acked-by: Heiko Carstens for the s390 part.