Re: [PATCH v10 03/16] s390/vfio-ap: manage link between queue struct and matrix mdev

Christian Borntraeger
2020-09-04T08:15:48Z

On 21.08.20 21:56, Tony Krowiak wrote:
> diff --git a/drivers/s390/crypto/vfio_ap_private.h b/drivers/s390/crypto/vfio_ap_private.h
> index a2aa05bec718..57da703b549a 100644
> --- a/drivers/s390/crypto/vfio_ap_private.h
> +++ b/drivers/s390/crypto/vfio_ap_private.h
> @@ -87,6 +87,7 @@ struct ap_matrix_mdev {
> struct kvm *kvm;
> struct kvm_s390_module_hook pqap_hook;
> struct mdev_device *mdev;
> + DECLARE_HASHTABLE(qtable, 8);
> };

Ah I think the include should go into this patch. But then you should revisit the patch description
of 2 as it talks about hashtables (but doesnt do anything about it).