From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:36890 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgICI0N (ORCPT ); Thu, 3 Sep 2020 04:26:13 -0400 Date: Thu, 3 Sep 2020 10:26:09 +0200 From: Christoph Hellwig Subject: Re: [PATCH 2/9] block: add a bdev_is_partition helper Message-ID: <20200903082609.GA23498@lst.de> References: <20200903054104.228829-1-hch@lst.de> <20200903054104.228829-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-s390-owner@vger.kernel.org List-ID: To: Ulf Hansson Cc: Christoph Hellwig , Jens Axboe , dm-devel@redhat.com, Linux Documentation , Linux Kernel Mailing List , linux-block , drbd-dev@lists.linbit.com, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, "linux-mmc@vger.kernel.org" , linux-s390@vger.kernel.org, linux-scsi , target-devel@vger.kernel.org On Thu, Sep 03, 2020 at 10:19:34AM +0200, Ulf Hansson wrote: > On Thu, 3 Sep 2020 at 07:42, Christoph Hellwig wrote: > > > > Add a littler helper to make the somewhat arcane bd_contains checks a > > little more obvious. > > > > Signed-off-by: Christoph Hellwig > > Not sure why we have both "bd_contains" and "bd_partno", nevertheless, > feel free to add: Right now both are needed for how blkdev_get/put work. But I plan to eventual kill off bd_contains after some major surgery to that code.