Re: [PATCH v2 2/2] s390x: Add 3f program exception handler

Heiko Carstens
2020-09-08T07:53:46Z

Hi Janosch,

On Tue, Sep 08, 2020 at 05:56:19AM +0800, kernel test robot wrote:
> All warnings (new ones prefixed by >>):
>
> >> arch/s390/mm/fault.c:862:6: warning: no previous prototype for 'do_secure_storage_violation' [-Wmissing-prototypes]
> 862 | void do_secure_storage_violation(struct pt_regs *regs)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> # https://github.com/0day-ci/linux/commit/4aee662164217d48d050e0d9cf57a2cb2cdeaa8a
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Janosch-Frank/s390x-pv-Fixes-and-improvements/20200908-021233
> git checkout 4aee662164217d48d050e0d9cf57a2cb2cdeaa8a
> vim +/do_secure_storage_violation +862 arch/s390/mm/fault.c
>
> 861
> > 862 void do_secure_storage_violation(struct pt_regs *regs)

To get rid of this warning, please add the function prototype to
arch/s390/kernel/entry.h. Like we have them for all other program
check handlers for this reason as well.