Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware

Dave Hansen
2020-09-08T14:33:24Z

On 9/7/20 11:00 AM, Gerald Schaefer wrote:
> x86:
> add/remove: 0/0 grow/shrink: 2/0 up/down: 10/0 (10)
> Function old new delta
> vmemmap_populate 587 592 +5
> munlock_vma_pages_range 556 561 +5
> Total: Before=15534694, After=15534704, chg +0.00%
...
> arch/x86/mm/init_64.c | 15 ++++-----
> arch/x86/mm/kasan_init_64.c | 16 +++++-----

I didn't do a super thorough review on this, but it generally looks OK
and the benefits of sharing more code between arches certainly outweigh
a few bytes of binary growth. For the x86 bits at least, feel free to
add my ack.