Re: [PATCH v3] s390x: Add 3f program exception handler

Janosch Frank
2020-09-08T15:57:12Z

[-- Attachment #1.1: Type: text/plain, Size: 1349 bytes --]

On 9/8/20 3:06 PM, Heiko Carstens wrote:
> On Tue, Sep 08, 2020 at 09:05:04AM -0400, Janosch Frank wrote:
>> Program exception 3f (secure storage violation) can only be detected
>> when the CPU is running in SIE with a format 4 state description,
>> e.g. running a protected guest. Because of this and because user
>> space partly controls the guest memory mapping and can trigger this
>> exception, we want to send a SIGSEGV to the process running the guest
>> and not panic the kernel.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> CC: <stable@vger.kernel.org> # 5.7+
>> Fixes: 084ea4d611a3 ("s390/mm: add (non)secure page access exceptions handlers")
>> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> arch/s390/kernel/entry.h | 1 +
>> arch/s390/kernel/pgm_check.S | 2 +-
>> arch/s390/mm/fault.c | 20 ++++++++++++++++++++
>> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> I guess this should go upstream via the s390 tree?

Christian asked the exact same question.
I think we picked the secure/non-secure exception handlers via the s390
tree so bringing these in via s390 would be in line with that.

> Should I pick this up?

That would be nice

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]