From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:36340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbgIIHQg (ORCPT ); Wed, 9 Sep 2020 03:16:36 -0400 Date: Wed, 9 Sep 2020 09:16:46 +0200 From: Greg Kroah-Hartman Subject: Re: [PATCH v2 2/7] kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGED Message-ID: <20200909071646.GC435421@kroah.com> References: <20200908201012.44168-1-david@redhat.com> <20200908201012.44168-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200908201012.44168-3-david@redhat.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org, Andrew Morton , Michal Hocko , Dan Williams , Jason Gunthorpe , Kees Cook , Ard Biesheuvel , Pankaj Gupta , Baoquan He , Wei Yang , Eric Biederman , Thomas Gleixner , kexec@lists.infradead.org On Tue, Sep 08, 2020 at 10:10:07PM +0200, David Hildenbrand wrote: > IORESOURCE_MEM_DRIVER_MANAGED currently uses an unused PnP bit, which is > always set to 0 by hardware. This is far from beautiful (and confusing), > and the bit only applies to SYSRAM. So let's move it out of the > bus-specific (PnP) defined bits. > > We'll add another SYSRAM specific bit soon. If we ever need more bits for > other purposes, we can steal some from "desc", or reshuffle/regroup what we > have. > > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Dan Williams > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Ard Biesheuvel > Cc: Pankaj Gupta > Cc: Baoquan He > Cc: Wei Yang > Cc: Eric Biederman > Cc: Thomas Gleixner > Cc: Greg Kroah-Hartman > Cc: kexec@lists.infradead.org > Signed-off-by: David Hildenbrand > --- > include/linux/ioport.h | 4 +++- > kernel/kexec_file.c | 2 +- > mm/memory_hotplug.c | 4 ++-- > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/linux/ioport.h b/include/linux/ioport.h > index 52a91f5fa1a36..d7620d7c941a0 100644 > --- a/include/linux/ioport.h > +++ b/include/linux/ioport.h > @@ -58,6 +58,9 @@ struct resource { > #define IORESOURCE_EXT_TYPE_BITS 0x01000000 /* Resource extended types */ > #define IORESOURCE_SYSRAM 0x01000000 /* System RAM (modifier) */ > > +/* IORESOURCE_SYSRAM specific bits. */ > +#define IORESOURCE_SYSRAM_DRIVER_MANAGED 0x02000000 /* Always detected via a driver. */ > + Can't you use BIT() here? thanks, greg k-h