From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:31976 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729992AbgJHOQt (ORCPT ); Thu, 8 Oct 2020 10:16:49 -0400 Date: Thu, 8 Oct 2020 16:16:37 +0200 From: Cornelia Huck Subject: Re: [PATCH v2 05/10] s390/dasd: Move duplicate code to separate function Message-ID: <20201008161637.2dbb321c.cohuck@redhat.com> In-Reply-To: <20201008131336.61100-6-sth@linux.ibm.com> References: <20201008131336.61100-1-sth@linux.ibm.com> <20201008131336.61100-6-sth@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-ID: To: Stefan Haberland Cc: Jens Axboe , linux-block@vger.kernel.org, Jan Hoeppner , linux-s390@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger On Thu, 8 Oct 2020 15:13:31 +0200 Stefan Haberland wrote: > From: Jan H=C3=B6ppner >=20 > For storing retrieved path information both the if and else block in > dasd_eckd_read_conf() use the same code. To avoid duplicate code this > should be done after the if/else block. To further increase readability, > move the code to a new function, dasd_eckd_store_conf_data(). >=20 > Signed-off-by: Jan H=C3=B6ppner > Reviewed-by: Stefan Haberland > Signed-off-by: Stefan Haberland > --- > drivers/s390/block/dasd_eckd.c | 42 ++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 22 deletions(-) Reviewed-by: Cornelia Huck