From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:36466 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbgKCJcv (ORCPT ); Tue, 3 Nov 2020 04:32:51 -0500 Date: Tue, 3 Nov 2020 10:32:32 +0100 From: Christoph Hellwig Subject: Re: [PATCH 06/11] md: implement ->set_read_only to hook into BLKROSET processing Message-ID: <20201103093232.GB17061@lst.de> References: <20201031085810.450489-1-hch@lst.de> <20201031085810.450489-7-hch@lst.de> <87y2jjpa09.fsf@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y2jjpa09.fsf@canonical.com> List-ID: To: James Troup Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , Song Liu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Stefan Haberland , Jan Hoeppner , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org On Tue, Nov 03, 2020 at 12:19:34AM +0000, James Troup wrote: > Christoph Hellwig writes: > > > @@ -7809,6 +7778,36 @@ static int md_compat_ioctl(struct block_device *bdev, fmode_t mode, > > [...] > > > + * Transitioning to readauto need only happen for arrays that call > > + * md_write_start and which are not ready for writes yet. > > I realise you're just moving the comment around but perhaps you could > s/readauto/readonly/ while you're doing so? readonly doesn't make sense here as we transition away from read-only. MD seems to have a read-auto mode, although it usually is spelled with the dash, so I'll switch this comment to use the more common spelling.