Re: [PATCH 2/5] block: simplify and extended the block_bio_merge tracepoint class

Hannes Reinecke
2020-12-03T12:47:14Z

On 11/30/20 6:58 PM, Christoph Hellwig wrote:
> The block_bio_merge tracepoint class can be reused for most bio-based
> tracepoints. For that is just needs to lose the superflous and rq

'and rq' ?
Do you mean 'q and rq'?

> parameters.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-core.c | 2 +-
> block/blk-merge.c | 4 +-
> block/blk-mq.c | 2 +-
> block/bounce.c | 2 +-
> include/trace/events/block.h | 158 ++++++++---------------------------
> kernel/trace/blktrace.c | 41 +++------
> 6 files changed, 48 insertions(+), 161 deletions(-)
>
Otherwise:

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer