Re: [PATCH v13 09/15] s390/vfio-ap: allow hot plug/unplug of AP resources using mdev device

Halil Pasic
2021-01-12T17:56:44Z

On Tue, 12 Jan 2021 02:12:51 +0100
Halil Pasic <pasic@linux.ibm.com> wrote:

> > @@ -1347,8 +1437,11 @@ void vfio_ap_mdev_remove_queue(struct ap_device *apdev)
> > apqi = AP_QID_QUEUE(q->apqn);
> > vfio_ap_mdev_reset_queue(apid, apqi, 1);
> >
> > - if (q->matrix_mdev)
> > + if (q->matrix_mdev) {
> > + matrix_mdev = q->matrix_mdev;
> > vfio_ap_mdev_unlink_queue(q);
> > + vfio_ap_mdev_refresh_apcb(matrix_mdev);
> > + }
> >
> > kfree(q);
> > mutex_unlock(&matrix_dev->lock);

Shouldn't we first remove the queue from the APCB and then
reset? Sorry, I missed this one yesterday.

Regards,
Halil