From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbhAETBZ (ORCPT ); Tue, 5 Jan 2021 14:01:25 -0500 From: Vladimir Oltean Subject: [RFC PATCH v2 net-next 00/12] Make .ndo_get_stats64 sleepable Date: Tue, 5 Jan 2021 20:58:50 +0200 Message-Id: <20210105185902.3922928-1-olteanv@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-ID: To: "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Paul Gortmaker , Pablo Neira Ayuso , Jiri Benc , Cong Wang , Jamal Hadi Salim , Stephen Hemminger , Eric Dumazet , George McCollister , Oleksij Rempel , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Arnd Bergmann , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Taehee Yoo , Jiri Pirko , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Paolo Abeni , Christian Brauner , Florian Westphal , linux-s390@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-parisc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, dev@openvswitch.org From: Vladimir Oltean Changes in v2: - Addressed the recursion issues in .ndo_get_stats64 from bonding and net_failover. - Renamed netdev_lists_lock to netif_lists_lock - Stopped taking netif_lists_lock from drivers as much as possible. This series converts all callers of dev_get_stats() to be in sleepable context, so that we can do more work in the .ndo_get_stats64 method. The situation today is that if we have hardware that needs to be accessed through a slow bus like SPI, or through a firmware, we cannot do that directly in .ndo_get_stats64, so we have to poll counters periodically and return a cached (not up to date) copy in the atomic NDO callback. This is undesirable on both ends: more work than strictly needed is being done, and the end result is also worse (not guaranteed to be up to date). So converting the code paths to be compatible with sleeping seems to make more sense. This is marked as Request For Comments for a reason. Cc: Leon Romanovsky Cc: Heiko Carstens Cc: Vasily Gorbik Cc: linux-s390@vger.kernel.org Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: Sridhar Samudrala Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-parisc@vger.kernel.org Cc: Christian Brauner Vladimir Oltean (12): net: mark dev_base_lock for deprecation net: introduce a mutex for the netns interface lists net: procfs: hold netif_lists_lock when retrieving device statistics net: sysfs: don't hold dev_base_lock while retrieving device statistics s390/appldata_net_sum: hold the netdev lists lock when retrieving device statistics parisc/led: reindent the code that gathers device statistics parisc/led: hold the netdev lists lock when retrieving device statistics net: make dev_get_stats return void net: net_failover: ensure .ndo_get_stats64 can sleep net: bonding: ensure .ndo_get_stats64 can sleep net: mark ndo_get_stats64 as being able to sleep net: remove obsolete comments about ndo_get_stats64 context from eth drivers Documentation/networking/netdevices.rst | 8 +- Documentation/networking/statistics.rst | 9 +- arch/s390/appldata/appldata_net_sum.c | 33 ++--- drivers/leds/trigger/ledtrig-netdev.c | 9 +- drivers/net/bonding/bond_main.c | 121 +++++++++--------- drivers/net/ethernet/cisco/enic/enic_main.c | 1 - .../net/ethernet/hisilicon/hns/hns_ethtool.c | 51 ++++---- .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 7 +- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 7 +- drivers/net/ethernet/nvidia/forcedeth.c | 2 - drivers/net/ethernet/sfc/efx_common.c | 1 - drivers/net/ethernet/sfc/falcon/efx.c | 1 - drivers/net/net_failover.c | 63 ++++++--- drivers/parisc/led.c | 37 +++--- drivers/scsi/fcoe/fcoe_transport.c | 6 +- drivers/usb/gadget/function/rndis.c | 45 +++---- include/linux/netdevice.h | 13 +- include/net/bonding.h | 52 +++++++- include/net/net_failover.h | 9 +- include/net/net_namespace.h | 6 + net/8021q/vlanproc.c | 15 +-- net/core/dev.c | 69 ++++++---- net/core/net-procfs.c | 48 +++---- net/core/net-sysfs.c | 10 +- net/openvswitch/vport.c | 25 ++-- 25 files changed, 372 insertions(+), 276 deletions(-) -- 2.25.1