Re: [kvm-unit-tests PATCH v2 8/8] s390x: Remove SAVE/RESTORE_stack

Janosch Frank
2021-02-17T16:47:22Z

On 2/17/21 5:18 PM, Thomas Huth wrote:
> On 17/02/2021 15.41, Janosch Frank wrote:
>> There are no more users.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> s390x/macros.S | 29 -----------------------------
>> 1 file changed, 29 deletions(-)
>>
>> diff --git a/s390x/macros.S b/s390x/macros.S
>> index 212a3823..399a87c6 100644
>> --- a/s390x/macros.S
>> +++ b/s390x/macros.S
>> @@ -28,35 +28,6 @@
>> lpswe \old_psw
>> .endm
>>
>> - .macro SAVE_REGS
>> - /* save grs 0-15 */
>> - stmg %r0, %r15, GEN_LC_SW_INT_GRS
>> - /* save crs 0-15 */
>> - stctg %c0, %c15, GEN_LC_SW_INT_CRS
>> - /* load a cr0 that has the AFP control bit which enables all FPRs */
>> - larl %r1, initial_cr0
>> - lctlg %c0, %c0, 0(%r1)
>> - /* save fprs 0-15 + fpc */
>> - la %r1, GEN_LC_SW_INT_FPRS
>> - .irp i, 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
>> - std \i, \i * 8(%r1)
>> - .endr
>> - stfpc GEN_LC_SW_INT_FPC
>> - .endm
>> -
>> - .macro RESTORE_REGS
>> - /* restore fprs 0-15 + fpc */
>> - la %r1, GEN_LC_SW_INT_FPRS
>> - .irp i, 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
>> - ld \i, \i * 8(%r1)
>> - .endr
>> - lfpc GEN_LC_SW_INT_FPC
>
> Could we now also remove the sw_int_fprs and sw_int_fpc from the lowcore?
>
> Thomas
>

git grep tells me that we can.
Do you want to have both the offset macro and the struct member removed
or only the macro?

We'll still need the grs and crs for the cpu setup in lib/s390x/smp.c