Re: [PATCH 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes

Jason Gunthorpe
2021-04-06T18:34:14Z

On Tue, Mar 23, 2021 at 08:31:03PM +0100, Christoph Hellwig wrote:

> > - type = intel_gvt_find_vgpu_type(gvt, mtype_get_type_group_id(kobj));
> > + type = intel_gvt_find_vgpu_type(gvt, mtype_get_type_group_id(mtype));
>
> Somewhere in this series you should probably switch
> intel_gvt_find_vgpu_type to only get the mtype, as it can trivially
> deduct the gvt from it (which also seems to have lost its type
> somewhere..)

I look at just this minor change for a bit and it just is a mess.

This only exists like this because the gvt_type_attrs[] are in the
wrong file and I already tried to fix that and gave up.

Deleting the intel_gvt_ops looks like precondition to do any big
improvement in here :\

Jason