Re: [PATCH v7 0/4] KVM statistics data fd-based binary interface

Paolo Bonzini
2021-06-11T11:02:35Z

On 11/06/21 08:57, Christian Borntraeger wrote:
>
> On 03.06.21 23:14, Jing Zhang wrote:
>> This patchset provides a file descriptor for every VM and VCPU to read
>> KVM statistics data in binary format.
>> It is meant to provide a lightweight, flexible, scalable and efficient
>> lock-free solution for user space telemetry applications to pull the
>> statistics data periodically for large scale systems. The pulling
>> frequency could be as high as a few times per second.
>> In this patchset, every statistics data are treated to have some
>> attributes as below:
>>    * architecture dependent or generic
>>    * VM statistics data or VCPU statistics data
>
> Are the debugfs things good enough, or do we want to also add the same
> ioctl for the /dev/kvm to get the global counters as well, e.g. for
> tools like kvm_stat?

I think we should, yes. We should also add the summarized VCPU
statistics to the VM-level file descriptor. However, it can be done in
steps.

Paolo