* [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390 [not found] <YMtib5hKVyNknZt3@osiris> @ 2021-06-17 19:31 ` Nathan Chancellor 2021-06-17 19:59 ` Nick Desaulniers 2021-06-18 8:42 ` Heiko Carstens 0 siblings, 2 replies; 4+ messages in thread From: Nathan Chancellor @ 2021-06-17 19:31 UTC (permalink / raw) To: Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Masahiro Yamada Cc: Nick Desaulniers, linux-kernel, clang-built-linux, linux-s390, linux-next, lkft-triage, Arnd Bergmann, Stephen Rothwell, Nathan Chancellor, Naresh Kamboju clang versions prior to the current development version of 13.0.0 cannot compile s390 after commit 3abbdfde5a65 ("s390/bitops: use register pair instead of register asm") and the s390 maintainers do not intend to work around this in the kernel. Codify this in scripts/min-tool-version.sh similar to arm64 with GCC 5.1.0 so that there are no reports of broken builds. Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- This should probably go through the s390 tree with Masahiro's ack. scripts/min-tool-version.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh index d22cf91212b0..319f92104f56 100755 --- a/scripts/min-tool-version.sh +++ b/scripts/min-tool-version.sh @@ -30,7 +30,12 @@ icc) echo 16.0.3 ;; llvm) - echo 10.0.1 + # https://lore.kernel.org/r/YMtib5hKVyNknZt3@osiris/ + if [ "$SRCARCH" = s390 ]; then + echo 13.0.0 + else + echo 10.0.1 + fi ;; *) echo "$1: unknown tool" >&2 base-commit: 7d9c6b8147bdd76d7eb2cf6f74f84c6918ae0939 -- 2.32.0.93.g670b81a890 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390 2021-06-17 19:31 ` [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390 Nathan Chancellor @ 2021-06-17 19:59 ` Nick Desaulniers 2021-06-18 8:42 ` Heiko Carstens 1 sibling, 0 replies; 4+ messages in thread From: Nick Desaulniers @ 2021-06-17 19:59 UTC (permalink / raw) To: Nathan Chancellor Cc: Heiko Carstens, Vasily Gorbik, Christian Borntraeger, Masahiro Yamada, LKML, clang-built-linux, linux-s390, Linux Next Mailing List, lkft-triage, Arnd Bergmann, Stephen Rothwell, Naresh Kamboju On Thu, Jun 17, 2021 at 12:32 PM Nathan Chancellor <nathan@kernel.org> wrote: > > clang versions prior to the current development version of 13.0.0 cannot > compile s390 after commit 3abbdfde5a65 ("s390/bitops: use register pair > instead of register asm") and the s390 maintainers do not intend to work > around this in the kernel. Codify this in scripts/min-tool-version.sh > similar to arm64 with GCC 5.1.0 so that there are no reports of broken > builds. > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Acked-by: Nick Desaulniers <ndesaulniers@google.com> > --- > > This should probably go through the s390 tree with Masahiro's ack. > > scripts/min-tool-version.sh | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh > index d22cf91212b0..319f92104f56 100755 > --- a/scripts/min-tool-version.sh > +++ b/scripts/min-tool-version.sh > @@ -30,7 +30,12 @@ icc) > echo 16.0.3 > ;; > llvm) > - echo 10.0.1 > + # https://lore.kernel.org/r/YMtib5hKVyNknZt3@osiris/ > + if [ "$SRCARCH" = s390 ]; then > + echo 13.0.0 > + else > + echo 10.0.1 > + fi > ;; > *) > echo "$1: unknown tool" >&2 > > base-commit: 7d9c6b8147bdd76d7eb2cf6f74f84c6918ae0939 > -- > 2.32.0.93.g670b81a890 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210617193139.856957-1-nathan%40kernel.org. -- Thanks, ~Nick Desaulniers ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390 2021-06-17 19:31 ` [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390 Nathan Chancellor 2021-06-17 19:59 ` Nick Desaulniers @ 2021-06-18 8:42 ` Heiko Carstens 2021-06-19 0:40 ` Masahiro Yamada 1 sibling, 1 reply; 4+ messages in thread From: Heiko Carstens @ 2021-06-18 8:42 UTC (permalink / raw) To: Nathan Chancellor Cc: Vasily Gorbik, Christian Borntraeger, Masahiro Yamada, Nick Desaulniers, linux-kernel, clang-built-linux, linux-s390, linux-next, lkft-triage, Arnd Bergmann, Stephen Rothwell, Naresh Kamboju On Thu, Jun 17, 2021 at 12:31:40PM -0700, Nathan Chancellor wrote: > clang versions prior to the current development version of 13.0.0 cannot > compile s390 after commit 3abbdfde5a65 ("s390/bitops: use register pair > instead of register asm") and the s390 maintainers do not intend to work > around this in the kernel. Codify this in scripts/min-tool-version.sh > similar to arm64 with GCC 5.1.0 so that there are no reports of broken > builds. > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > > This should probably go through the s390 tree with Masahiro's ack. Thank's a lot! I'll add the below text to the commit message, and apply it internally first: [hca@linux.ibm.com: breaking compatibility with older clang compilers is intended to finally make use of a feature which allows the compiler to allocate even/odd register pairs. This is possible since a very long time with gcc, but only since llvm-project commit d058262b1471 ("[SystemZ] Support i128 inline asm operands.") with clang. Using that feature allows to get rid of error prone register asm statements, of which the above named kernel commit is only the first of a larger not yet complete series] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390 2021-06-18 8:42 ` Heiko Carstens @ 2021-06-19 0:40 ` Masahiro Yamada 0 siblings, 0 replies; 4+ messages in thread From: Masahiro Yamada @ 2021-06-19 0:40 UTC (permalink / raw) To: Heiko Carstens Cc: Nathan Chancellor, Vasily Gorbik, Christian Borntraeger, Nick Desaulniers, Linux Kernel Mailing List, clang-built-linux, linux-s390, Linux-Next Mailing List, lkft-triage, Arnd Bergmann, Stephen Rothwell, Naresh Kamboju On Fri, Jun 18, 2021 at 5:42 PM Heiko Carstens <hca@linux.ibm.com> wrote: > > On Thu, Jun 17, 2021 at 12:31:40PM -0700, Nathan Chancellor wrote: > > clang versions prior to the current development version of 13.0.0 cannot > > compile s390 after commit 3abbdfde5a65 ("s390/bitops: use register pair > > instead of register asm") and the s390 maintainers do not intend to work > > around this in the kernel. Codify this in scripts/min-tool-version.sh > > similar to arm64 with GCC 5.1.0 so that there are no reports of broken > > builds. > > > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > > --- > > > > This should probably go through the s390 tree with Masahiro's ack. Acked-by: Masahiro Yamada <masahiroy@kernel.org> > Thank's a lot! > > I'll add the below text to the commit message, and apply it internally > first: > > [hca@linux.ibm.com: breaking compatibility with older clang compilers > is intended to finally make use of a feature which allows the > compiler to allocate even/odd register pairs. This is possible since > a very long time with gcc, but only since llvm-project commit > d058262b1471 ("[SystemZ] Support i128 inline asm operands.") with > clang. Using that feature allows to get rid of error prone register > asm statements, of which the above named kernel commit is only the > first of a larger not yet complete series] > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/YMxcdv/1taBevSjP%40osiris. -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-19 0:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <YMtib5hKVyNknZt3@osiris>
2021-06-17 19:31 ` [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390 Nathan Chancellor
2021-06-17 19:59 ` Nick Desaulniers
2021-06-18 8:42 ` Heiko Carstens
2021-06-19 0:40 ` Masahiro Yamada
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).