From: Janosch Frank <frankja@linux.ibm.com>
To: pbonzini@redhat.com
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com,
borntraeger@de.ibm.com, cohuck@redhat.com,
linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
thuth@redhat.com
Subject: [kvm-unit-tests GIT PULL 02/12] s390x: selftest: Add prefixes to fix report output
Date: Tue, 22 Jun 2021 10:20:32 +0200 [thread overview]
Message-ID: <20210622082042.13831-3-frankja@linux.ibm.com> (raw)
In-Reply-To: <20210622082042.13831-1-frankja@linux.ibm.com>
To make our TAP parser (and me) happy we don't want to have two reports
with exactly the same wording so I added in two new prefix pushes.
Also moving the code inside of the region of a prefix will give us
more data when a problem arises.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
s390x/selftest.c | 26 ++++++++++++++++++--------
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/s390x/selftest.c b/s390x/selftest.c
index b2fe2e7b..0f099ca0 100644
--- a/s390x/selftest.c
+++ b/s390x/selftest.c
@@ -40,19 +40,28 @@ static void test_pgm_int(void)
static void test_malloc(void)
{
- int *tmp = malloc(sizeof(int));
- int *tmp2 = malloc(sizeof(int));
+ int *tmp, *tmp2;
+ report_prefix_push("malloc");
+
+ report_prefix_push("ptr_0");
+ tmp = malloc(sizeof(int));
+ report((uintptr_t)tmp & 0xf000000000000000ul, "allocated memory");
*tmp = 123456789;
+ mb();
+ report(*tmp == 123456789, "wrote allocated memory");
+ report_prefix_pop();
+
+ report_prefix_push("ptr_1");
+ tmp2 = malloc(sizeof(int));
+ report((uintptr_t)tmp2 & 0xf000000000000000ul,
+ "allocated memory");
*tmp2 = 123456789;
mb();
+ report((*tmp2 == 123456789), "wrote allocated memory");
+ report_prefix_pop();
- report((uintptr_t)tmp & 0xf000000000000000ul, "malloc: got vaddr");
- report(*tmp == 123456789, "malloc: access works");
- report((uintptr_t)tmp2 & 0xf000000000000000ul,
- "malloc: got 2nd vaddr");
- report((*tmp2 == 123456789), "malloc: access works");
- report(tmp != tmp2, "malloc: addresses differ");
+ report(tmp != tmp2, "allocated memory addresses differ");
expect_pgm_int();
configure_dat(0);
@@ -62,6 +71,7 @@ static void test_malloc(void)
free(tmp);
free(tmp2);
+ report_prefix_pop();
}
int main(int argc, char**argv)
--
2.31.1
next prev parent reply other threads:[~2021-06-22 8:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 8:20 [kvm-unit-tests GIT PULL 00/12] s390x update 2021-22-06 Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 01/12] s390x: sie: Only overwrite r3 if it isn't needed anymore Janosch Frank
2021-06-22 8:20 ` Janosch Frank [this message]
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 03/12] s390x: Don't run PV testcases under tcg Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 04/12] configure: s390x: Check if the host key document exists Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 05/12] s390x: run: Skip PV tests when tcg is the accelerator Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 06/12] s390x: lib: add and use macros for control register bits Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 07/12] libcflat: add SZ_1M and SZ_2G Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 08/12] s390x: lib: fix pgtable.h Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 09/12] s390x: lib: Add idte and other huge pages functions/macros Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 10/12] s390x: lib: add teid union and clear teid from lowcore Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 11/12] s390x: mmu: add support for large pages Janosch Frank
2021-06-22 8:20 ` [kvm-unit-tests GIT PULL 12/12] s390x: edat test Janosch Frank
2021-06-22 8:24 ` [kvm-unit-tests GIT PULL 00/12] s390x update 2021-22-06 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622082042.13831-3-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).