From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, thuth@redhat.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH 3/5] lib: s390x: uv: Int type cleanup
Date: Tue, 29 Jun 2021 13:33:20 +0000 [thread overview]
Message-ID: <20210629133322.19193-4-frankja@linux.ibm.com> (raw)
In-Reply-To: <20210629133322.19193-1-frankja@linux.ibm.com>
These structs have largely been copied from the kernel so they still
have the old uint short types which we want to avoid in favor of the
uint*_t ones.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
lib/s390x/asm/uv.h | 142 +++++++++++++++++++++++----------------------
1 file changed, 72 insertions(+), 70 deletions(-)
diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
index dc3e02d..96a2a7e 100644
--- a/lib/s390x/asm/uv.h
+++ b/lib/s390x/asm/uv.h
@@ -12,6 +12,8 @@
#ifndef _ASMS390X_UV_H_
#define _ASMS390X_UV_H_
+#include <stdint.h>
+
#define UVC_RC_EXECUTED 0x0001
#define UVC_RC_INV_CMD 0x0002
#define UVC_RC_INV_STATE 0x0003
@@ -68,73 +70,73 @@ enum uv_cmds_inst {
};
struct uv_cb_header {
- u16 len;
- u16 cmd; /* Command Code */
- u16 rc; /* Response Code */
- u16 rrc; /* Return Reason Code */
+ uint16_t len;
+ uint16_t cmd; /* Command Code */
+ uint16_t rc; /* Response Code */
+ uint16_t rrc; /* Return Reason Code */
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_init {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 stor_origin;
- u64 stor_len;
- u64 reserved28[4];
+ uint64_t reserved08[2];
+ uint64_t stor_origin;
+ uint64_t stor_len;
+ uint64_t reserved28[4];
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_qui {
struct uv_cb_header header;
- u64 reserved08;
- u64 inst_calls_list[4];
- u64 reserved30[2];
- u64 uv_base_stor_len;
- u64 reserved48;
- u64 conf_base_phys_stor_len;
- u64 conf_base_virt_stor_len;
- u64 conf_virt_var_stor_len;
- u64 cpu_stor_len;
- u32 reserved70[3];
- u32 max_num_sec_conf;
- u64 max_guest_stor_addr;
- u8 reserved88[158 - 136];
- u16 max_guest_cpus;
- u8 reserveda0[200 - 160];
+ uint64_t reserved08;
+ uint64_t inst_calls_list[4];
+ uint64_t reserved30[2];
+ uint64_t uv_base_stor_len;
+ uint64_t reserved48;
+ uint64_t conf_base_phys_stor_len;
+ uint64_t conf_base_virt_stor_len;
+ uint64_t conf_virt_var_stor_len;
+ uint64_t cpu_stor_len;
+ uint32_t reserved70[3];
+ uint32_t max_num_sec_conf;
+ uint64_t max_guest_stor_addr;
+ uint8_t reserved88[158 - 136];
+ uint16_t max_guest_cpus;
+ uint8_t reserveda0[200 - 160];
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_cgc {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 guest_handle;
- u64 conf_base_stor_origin;
- u64 conf_var_stor_origin;
- u64 reserved30;
- u64 guest_stor_origin;
- u64 guest_stor_len;
- u64 guest_sca;
- u64 guest_asce;
- u64 reserved60[5];
+ uint64_t reserved08[2];
+ uint64_t guest_handle;
+ uint64_t conf_base_stor_origin;
+ uint64_t conf_var_stor_origin;
+ uint64_t reserved30;
+ uint64_t guest_stor_origin;
+ uint64_t guest_stor_len;
+ uint64_t guest_sca;
+ uint64_t guest_asce;
+ uint64_t reserved60[5];
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_csc {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 cpu_handle;
- u64 guest_handle;
- u64 stor_origin;
- u8 reserved30[6];
- u16 num;
- u64 state_origin;
- u64 reserved[4];
+ uint64_t reserved08[2];
+ uint64_t cpu_handle;
+ uint64_t guest_handle;
+ uint64_t stor_origin;
+ uint8_t reserved30[6];
+ uint16_t num;
+ uint64_t state_origin;
+ uint64_t reserved[4];
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_unp {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 guest_handle;
- u64 gaddr;
- u64 tweak[2];
- u64 reserved38[3];
+ uint64_t reserved08[2];
+ uint64_t guest_handle;
+ uint64_t gaddr;
+ uint64_t tweak[2];
+ uint64_t reserved38[3];
} __attribute__((packed)) __attribute__((aligned(8)));
/*
@@ -144,42 +146,42 @@ struct uv_cb_unp {
*/
struct uv_cb_nodata {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 handle;
- u64 reserved20[4];
+ uint64_t reserved08[2];
+ uint64_t handle;
+ uint64_t reserved20[4];
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_share {
struct uv_cb_header header;
- u64 reserved08[3];
- u64 paddr;
- u64 reserved28;
+ uint64_t reserved08[3];
+ uint64_t paddr;
+ uint64_t reserved28;
} __attribute__((packed)) __attribute__((aligned(8)));
/* Convert to Secure */
struct uv_cb_cts {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 guest_handle;
- u64 gaddr;
+ uint64_t reserved08[2];
+ uint64_t guest_handle;
+ uint64_t gaddr;
} __attribute__((packed)) __attribute__((aligned(8)));
/* Convert from Secure / Pin Page Shared */
struct uv_cb_cfs {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 paddr;
+ uint64_t reserved08[2];
+ uint64_t paddr;
} __attribute__((packed)) __attribute__((aligned(8)));
/* Set Secure Config Parameter */
struct uv_cb_ssc {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 guest_handle;
- u64 sec_header_origin;
- u32 sec_header_len;
- u32 reserved2c;
- u64 reserved30[4];
+ uint64_t reserved08[2];
+ uint64_t guest_handle;
+ uint64_t sec_header_origin;
+ uint32_t sec_header_len;
+ uint32_t reserved2c;
+ uint64_t reserved30[4];
} __attribute__((packed)) __attribute__((aligned(8)));
static inline int uv_call_once(unsigned long r1, unsigned long r2)
@@ -211,7 +213,7 @@ static inline int uv_call(unsigned long r1, unsigned long r2)
return cc;
}
-static inline int share(unsigned long addr, u16 cmd)
+static inline int share(unsigned long addr, uint16_t cmd)
{
struct uv_cb_share uvcb = {
.header.cmd = cmd,
@@ -220,7 +222,7 @@ static inline int share(unsigned long addr, u16 cmd)
};
int cc;
- cc = uv_call(0, (u64)&uvcb);
+ cc = uv_call(0, (uint64_t)&uvcb);
if (!cc && uvcb.header.rc == UVC_RC_EXECUTED)
return 0;
@@ -252,11 +254,11 @@ static inline int uv_remove_shared(unsigned long addr)
struct uv_cb_cpu_set_state {
struct uv_cb_header header;
- u64 reserved08[2];
- u64 cpu_handle;
- u8 reserved20[7];
- u8 state;
- u64 reserved28[5];
+ uint64_t reserved08[2];
+ uint64_t cpu_handle;
+ uint8_t reserved20[7];
+ uint8_t state;
+ uint64_t reserved28[5];
};
#define PV_CPU_STATE_OPR 1
--
2.30.2
next prev parent reply other threads:[~2021-06-29 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 13:33 [kvm-unit-tests PATCH 0/5] s390x: sie and uv cleanups Janosch Frank
2021-06-29 13:33 ` [kvm-unit-tests PATCH 1/5] s390x: sie: Add missing includes Janosch Frank
2021-06-30 8:59 ` Cornelia Huck
2021-07-04 7:47 ` Thomas Huth
2021-07-23 17:10 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 2/5] s390x: sie: Fix sie.h integer types Janosch Frank
2021-06-30 9:00 ` Cornelia Huck
2021-07-04 7:45 ` Thomas Huth
2021-07-23 17:10 ` Claudio Imbrenda
2021-06-29 13:33 ` Janosch Frank [this message]
2021-06-30 9:03 ` [kvm-unit-tests PATCH 3/5] lib: s390x: uv: Int type cleanup Cornelia Huck
2021-07-04 7:51 ` Thomas Huth
2021-07-05 9:33 ` Janosch Frank
2021-07-05 9:41 ` Thomas Huth
2021-07-23 17:15 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 4/5] lib: s390x: uv: Add offset comments to uv_query and extend it Janosch Frank
2021-06-30 9:06 ` Cornelia Huck
2021-06-30 9:43 ` Janosch Frank
2021-07-23 17:22 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 5/5] lib: s390x: Print if a pgm happened while in SIE Janosch Frank
2021-06-30 9:12 ` Cornelia Huck
2021-07-23 17:25 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629133322.19193-4-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox