From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, thuth@redhat.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH 4/5] lib: s390x: uv: Add offset comments to uv_query and extend it
Date: Tue, 29 Jun 2021 13:33:21 +0000 [thread overview]
Message-ID: <20210629133322.19193-5-frankja@linux.ibm.com> (raw)
In-Reply-To: <20210629133322.19193-1-frankja@linux.ibm.com>
The struct is getting longer, let's add offset comments so we know
where we change things when we add struct members.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
lib/s390x/asm/uv.h | 33 +++++++++++++++++----------------
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
index 96a2a7e..5ff98b8 100644
--- a/lib/s390x/asm/uv.h
+++ b/lib/s390x/asm/uv.h
@@ -86,22 +86,23 @@ struct uv_cb_init {
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_qui {
- struct uv_cb_header header;
- uint64_t reserved08;
- uint64_t inst_calls_list[4];
- uint64_t reserved30[2];
- uint64_t uv_base_stor_len;
- uint64_t reserved48;
- uint64_t conf_base_phys_stor_len;
- uint64_t conf_base_virt_stor_len;
- uint64_t conf_virt_var_stor_len;
- uint64_t cpu_stor_len;
- uint32_t reserved70[3];
- uint32_t max_num_sec_conf;
- uint64_t max_guest_stor_addr;
- uint8_t reserved88[158 - 136];
- uint16_t max_guest_cpus;
- uint8_t reserveda0[200 - 160];
+ struct uv_cb_header header; /* 0x0000 */
+ uint64_t reserved08; /* 0x0008 */
+ uint64_t inst_calls_list[4]; /* 0x0010 */
+ uint64_t reserved30[2]; /* 0x0030 */
+ uint64_t uv_base_stor_len; /* 0x0040 */
+ uint64_t reserved48; /* 0x0048 */
+ uint64_t conf_base_phys_stor_len; /* 0x0050 */
+ uint64_t conf_base_virt_stor_len; /* 0x0058 */
+ uint64_t conf_virt_var_stor_len; /* 0x0060 */
+ uint64_t cpu_stor_len; /* 0x0068 */
+ uint32_t reserved70[3]; /* 0x0070 */
+ uint32_t max_num_sec_conf; /* 0x007c */
+ uint64_t max_guest_stor_addr; /* 0x0080 */
+ uint8_t reserved88[158 - 136]; /* 0x0088 */
+ uint16_t max_guest_cpus; /* 0x009e */
+ uint64_t uv_feature_indications; /* 0x00a0 */
+ uint8_t reserveda0[200 - 168]; /* 0x00a8 */
} __attribute__((packed)) __attribute__((aligned(8)));
struct uv_cb_cgc {
--
2.30.2
next prev parent reply other threads:[~2021-06-29 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 13:33 [kvm-unit-tests PATCH 0/5] s390x: sie and uv cleanups Janosch Frank
2021-06-29 13:33 ` [kvm-unit-tests PATCH 1/5] s390x: sie: Add missing includes Janosch Frank
2021-06-30 8:59 ` Cornelia Huck
2021-07-04 7:47 ` Thomas Huth
2021-07-23 17:10 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 2/5] s390x: sie: Fix sie.h integer types Janosch Frank
2021-06-30 9:00 ` Cornelia Huck
2021-07-04 7:45 ` Thomas Huth
2021-07-23 17:10 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 3/5] lib: s390x: uv: Int type cleanup Janosch Frank
2021-06-30 9:03 ` Cornelia Huck
2021-07-04 7:51 ` Thomas Huth
2021-07-05 9:33 ` Janosch Frank
2021-07-05 9:41 ` Thomas Huth
2021-07-23 17:15 ` Claudio Imbrenda
2021-06-29 13:33 ` Janosch Frank [this message]
2021-06-30 9:06 ` [kvm-unit-tests PATCH 4/5] lib: s390x: uv: Add offset comments to uv_query and extend it Cornelia Huck
2021-06-30 9:43 ` Janosch Frank
2021-07-23 17:22 ` Claudio Imbrenda
2021-06-29 13:33 ` [kvm-unit-tests PATCH 5/5] lib: s390x: Print if a pgm happened while in SIE Janosch Frank
2021-06-30 9:12 ` Cornelia Huck
2021-07-23 17:25 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629133322.19193-5-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox