Re: [PATCH v1 01/16] dma-mapping: Allow map_sg() ops to return negative error codes

Christoph Hellwig
2021-07-16T06:29:33Z

On Thu, Jul 15, 2021 at 10:45:29AM -0600, Logan Gunthorpe wrote:
> + * dma_map_sgtable() will return the error code returned and convert
> + * a zero return (for legacy implementations) into -EINVAL.
> + *
> + * dma_map_sg() will always return zero on any negative or zero
> + * return to satisfy its own calling convention.
> */

I don't think this belongs here.

> +EXPORT_SYMBOL(dma_map_sgtable);

EXPORT_SYMBOL_GPL, please.