Re: [PATCH v3 3/9] hexagon: use generic strncpy/strnlen from_user

Christoph Hellwig
2021-07-22T13:00:29Z

On Thu, Jul 22, 2021 at 02:48:08PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Remove the hexagon implementation of strncpy/strnlen and instead use
> the generic version. The hexagon version reads the data twice for
> strncpy() by doing an extra strnlen(), and it apparently lacks a check
> for user_addr_max().
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>