Re: [kvm-unit-tests PATCH v1 2/4] s390x: lib: Move stsi_get_fc to library

Pierre Morel
2021-08-09T14:23:11Z

On 8/9/21 12:16 PM, Janosch Frank wrote:
> On 8/9/21 10:48 AM, Pierre Morel wrote:
>> It's needed in multiple tests now.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> lib/s390x/asm/arch_def.h | 16 ++++++++++++++++
>> s390x/stsi.c | 16 ----------------
>> 2 files changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
>> index 15cf7d48..57d7ddac 100644
>> --- a/lib/s390x/asm/arch_def.h
>> +++ b/lib/s390x/asm/arch_def.h
>> @@ -328,6 +328,22 @@ static inline int stsi(void *addr, int fc, int sel1, int sel2)
>> return cc;
>> }
>>
>> +static inline unsigned long stsi_get_fc(void *addr)
>
> We don't need an address for fc == 0. You can remove that and fix the
> s390x/stsi.c call.

OK, I do that.
Thanks,

Pierre

--
Pierre Morel
IBM Lab Boeblingen