Re: [PATCH V3 06/13] vfio/pci: Split the pci_driver code out of vfio_pci_core.c

Max Gurtovoy
2021-08-23T15:29:02Z

On 8/23/2021 6:16 PM, Alex Williamson wrote:
> On Sun, 22 Aug 2021 17:35:55 +0300
> Yishai Hadas <yishaih@nvidia.com> wrote:
>> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
>> new file mode 100644
>> index 000000000000..15474ebadd98
>> --- /dev/null
>> +++ b/drivers/vfio/pci/vfio_pci.c
> ...
>> +static int vfio_pci_sriov_configure(struct pci_dev *pdev, int nr_virtfn)
>> +{
>> + might_sleep();
>> +
>> + if (!enable_sriov)
>> + return -ENOENT;
>> +
>> + return vfio_pci_core_sriov_configure(pdev, nr_virtfn);
>> +}
> As noted in previous version, why do we need the might_sleep() above
> when the core code below includes it and there's nothing above that
> might sleep before that? Thanks,

This is used to mention vfio_pci_core_sriov_configure might sleep.

If this is redundant, can you please remove this one line upon merge ?

>
> Alex
>
>> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
>> index 94f062818e0c..87d1960d0d61 100644
>> --- a/drivers/vfio/pci/vfio_pci_core.c
>> +++ b/drivers/vfio/pci/vfio_pci_core.c
> ...
>> -static int vfio_pci_sriov_configure(struct pci_dev *pdev, int nr_virtfn)
>> +int vfio_pci_core_sriov_configure(struct pci_dev *pdev, int nr_virtfn)
>> {
>> struct vfio_device *device;
>> int ret = 0;
>>
>> might_sleep();
>>
>> - if (!enable_sriov)
>> - return -ENOENT;
>> -
>> device = vfio_device_get_from_dev(&pdev->dev);
>> if (!device)
>> return -ENODEV;