From: Jason Gunthorpe <jgg@nvidia.com>
To: Tony Krowiak <akrowiak@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>, Christoph Hellwig <hch@lst.de>,
kvm@vger.kernel.org
Subject: Re: [PATCH v4] vfio/ap_ops: Convert to use vfio_register_group_dev()
Date: Tue, 24 Aug 2021 09:08:52 -0300 [thread overview]
Message-ID: <20210824120852.GS1721383@nvidia.com> (raw)
In-Reply-To: <206c91b5-ad94-06d8-f187-d55d8708b7b2@linux.ibm.com>
On Mon, Aug 23, 2021 at 04:57:30PM -0400, Tony Krowiak wrote:
> > - if (!try_module_get(THIS_MODULE))
> > - return -ENODEV;
>
> Not a big deal, but why did you remove this? Isn't it beneficial to
> get a message that the module can't be removed until
> the last ref is released?
The core code does it now
Jason
next prev parent reply other threads:[~2021-08-24 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 14:42 [PATCH v4] vfio/ap_ops: Convert to use vfio_register_group_dev() Jason Gunthorpe
2021-08-23 20:57 ` Tony Krowiak
2021-08-24 12:08 ` Jason Gunthorpe [this message]
2021-08-24 20:30 ` Alex Williamson
2021-08-25 0:42 ` Jason Gunthorpe
2021-08-25 20:13 ` Alex Williamson
2021-08-25 22:21 ` Jason Gunthorpe
2021-08-26 22:20 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824120852.GS1721383@nvidia.com \
--to=jgg@nvidia.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).