From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DD94C433EF for ; Tue, 7 Sep 2021 10:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC67E610E9 for ; Tue, 7 Sep 2021 10:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232704AbhIGKWq (ORCPT ); Tue, 7 Sep 2021 06:22:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55920 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233477AbhIGKWp (ORCPT ); Tue, 7 Sep 2021 06:22:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631010099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f++tlxFdFC82weLDV66fZEVmzKayy0iCTttWnFQCXr8=; b=e6ZsVgtH6oRx1GPqy4h0nkawtKKqgyqd+P/u7N1oLUT3x15wm694WqmzVi4UKAiWDoK1kD FuaBKRSHBBE4HYWeEfLeBwB7qGA2WxCFrZ+uy1h9RMWoZEDzKgX3AsU/svPzPDAXs5dF0u AFBKlDZCxQ40VMtpyUQYb67I3BHOUHM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-L8stJX7DNEmqFn3_LvBmKQ-1; Tue, 07 Sep 2021 06:21:38 -0400 X-MC-Unique: L8stJX7DNEmqFn3_LvBmKQ-1 Received: by mail-wr1-f71.google.com with SMTP id q14-20020a5d574e000000b00157b0978ddeso1957930wrw.5 for ; Tue, 07 Sep 2021 03:21:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f++tlxFdFC82weLDV66fZEVmzKayy0iCTttWnFQCXr8=; b=ExRodlJtSEbqAy9nORUk99C2juRcMfWX7ow1Mcuov31SiAYatVM4z0d3MycnIfvJ1p DksUUbfu6rqQKAhbrdSwSjmyyx3jZW8KwIc4391a5Y8ilA/G8BrN9mk7R/nk0mEHUdjs koePZsmg0aiGfgy7zWhvuKcaAcYLZ955tzfhQ02HviCPgTFgA0Q47q0cgDDsFeDIRyT6 VkSPmWvLV7uKT9KREIYvajgZqNhnSUiflqttdYyra5soh2Qoy3hNytkDPeWv1s5j7M1O tDugl/LYqG7NKJXfBeNGkrphysltsnDBgFnUbrW+uoRkFCcM6B3+iLmClPFl3eoFmlUA sPzA== X-Gm-Message-State: AOAM5311YTGy8VL0A9dMCMUoTeQP1FNaTOqdhZH3ouZi9B5dVSrdk7a/ BAX7x5oW+a8eflfbtH4CcY3Uzbzokgy1NUQGmBt3WPqNkSmrqDC92h+LcZWe5VYJPaoh1Bcco6N PYxysBbdU6HhAxZOhmianEQ== X-Received: by 2002:a05:6000:1563:: with SMTP id 3mr18583595wrz.139.1631010097380; Tue, 07 Sep 2021 03:21:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVgROHRJDcbz9ILwMhdnSZ3oJA6YdR1KgI9MywkZ1Cjk4U3iVAKCDYVZQ+gA4/zuyHOdxqyQ== X-Received: by 2002:a05:6000:1563:: with SMTP id 3mr18583578wrz.139.1631010097179; Tue, 07 Sep 2021 03:21:37 -0700 (PDT) Received: from gator (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id p5sm11270858wrd.25.2021.09.07.03.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 03:21:36 -0700 (PDT) Date: Tue, 7 Sep 2021 12:21:35 +0200 From: Andrew Jones To: Alexandru Elisei Cc: thuth@redhat.com, pbonzini@redhat.com, lvivier@redhat.com, kvm-ppc@vger.kernel.org, david@redhat.com, frankja@linux.ibm.com, cohuck@redhat.com, imbrenda@linux.ibm.com, linux-s390@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, andre.przywara@arm.com, maz@kernel.org, vivek.gautam@arm.com Subject: Re: [kvm-unit-tests RFC PATCH 4/5] scripts: Generate kvmtool standalone tests Message-ID: <20210907102135.i2w3r7j4zyj736b5@gator> References: <20210702163122.96110-1-alexandru.elisei@arm.com> <20210702163122.96110-5-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210702163122.96110-5-alexandru.elisei@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Fri, Jul 02, 2021 at 05:31:21PM +0100, Alexandru Elisei wrote: > Add support for the standalone target when running kvm-unit-tests under > kvmtool. > > Example command line invocation: > > $ ./configure --target=kvmtool > $ make clean && make standalone > > Signed-off-by: Alexandru Elisei > --- > scripts/mkstandalone.sh | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh > index 16f461c06842..d84bdb7e278c 100755 > --- a/scripts/mkstandalone.sh > +++ b/scripts/mkstandalone.sh > @@ -44,6 +44,10 @@ generate_test () > config_export ARCH_NAME > config_export PROCESSOR > > + if [ "$ARCH" = "arm64" ] || [ "$ARCH" = "arm" ]; then > + config_export TARGET > + fi Should export unconditionally, since we'll want TARGET set unconditionally. > + > echo "echo BUILD_HEAD=$(cat build-head)" > > if [ ! -f $kernel ]; then > @@ -59,7 +63,7 @@ generate_test () > echo 'export FIRMWARE' > fi > > - if [ "$ENVIRON_DEFAULT" = "yes" ] && [ "$ERRATATXT" ]; then > + if [ "$TARGET" != "kvmtool" ] && [ "$ENVIRON_DEFAULT" = "yes" ] && [ "$ERRATATXT" ]; then I think it would be better to ensure that ENVIRON_DEFAULT is "no" for TARGET=kvmtool in configure. > temp_file ERRATATXT "$ERRATATXT" > echo 'export ERRATATXT' > fi > @@ -95,12 +99,8 @@ function mkstandalone() > echo Written $standalone. > } > > -if [ "$TARGET" = "kvmtool" ]; then > - echo "Standalone tests not supported with kvmtool" > - exit 2 > -fi > - > -if [ "$ENVIRON_DEFAULT" = "yes" ] && [ "$ERRATATXT" ] && [ ! -f "$ERRATATXT" ]; then > +if [ "$TARGET" != "kvmtool" ] && [ "$ENVIRON_DEFAULT" = "yes" ] && \ > + [ "$ERRATATXT" ] && [ ! -f "$ERRATATXT" ]; then > echo "$ERRATATXT not found. (ERRATATXT=$ERRATATXT)" >&2 > exit 2 > fi > -- > 2.32.0 > Thanks, drew