Re: [kvm-unit-tests PATCH v3 8/9] s390x: snippets: Set stackptr and stacktop in cstart.S

Thomas Huth
2021-10-07T09:13:23Z

On 07/10/2021 10.50, Janosch Frank wrote:
> We have a stack, so why not define it and be a step closer to include
> the lib into the snippets.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/snippets/c/cstart.S | 2 +-
> s390x/snippets/c/flat.lds | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/s390x/snippets/c/cstart.S b/s390x/snippets/c/cstart.S
> index a1754808..031a6b83 100644
> --- a/s390x/snippets/c/cstart.S
> +++ b/s390x/snippets/c/cstart.S
> @@ -17,7 +17,7 @@ start:
> xgr \i,\i
> .endr
> /* 0x3000 is the stack page for now */
> - lghi %r15, 0x4000 - 160
> + lghi %r15, stackptr

I already wanted to ask you to replace the magic value 0x4000 here ... great
to see that you already did it :-)

Reviewed-by: Thomas Huth <thuth@redhat.com>