Re: [PATCH 0/4] s390: DYNAMIC_FTRACE_WITH_DIRECT_CALL support

Steven Rostedt
2021-10-19T02:06:55Z

On Wed, 13 Oct 2021 10:48:20 +0200
Heiko Carstens <hca@linux.ibm.com> wrote:

> On Tue, Oct 12, 2021 at 08:25:14PM +0200, Heiko Carstens wrote:
> > On Tue, Oct 12, 2021 at 07:04:53PM +0200, Jiri Olsa wrote:
> > > > > See here:
> > > > >
> > > > > https://lore.kernel.org/all/20211008091336.33616-1-jolsa@kernel.org/
> > > >
> > > > I applied Jiri's patch set and the newly added selftest passes.
> > >
> > > nice, could I have your Tested-by? ;-)
> >
> > Well, now I added also the missing pieces to ftrace-direct-multi
> > sample module and when loading that and looking into
> > /sys/kernel/debug/tracing/trace it looks like "my_direct_func" gets
> > some random junk as parameter and nothing that could count as "ip".
> >
> > Will look into that, probably tomorrow.
>
> Ok, if I load the correct module, it even works. I had a bug in the
> first version, fixed it, but still loaded the broken module to test
> my changes. Clever me ;)
>
> So it all works for me.

BTW, in case you need my ack:

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

for the series.

-- Steve