From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD4D7C433FE for ; Mon, 13 Dec 2021 08:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231668AbhLMI1c (ORCPT ); Mon, 13 Dec 2021 03:27:32 -0500 Received: from verein.lst.de ([213.95.11.211]:46709 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231735AbhLMI1U (ORCPT ); Mon, 13 Dec 2021 03:27:20 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 8C12868BFE; Mon, 13 Dec 2021 09:27:15 +0100 (CET) Date: Mon, 13 Dec 2021 09:27:15 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Vishal Verma , Dave Jiang , Alasdair Kergon , Mike Snitzer , Ira Weiny , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Vivek Goyal , Stefan Hajnoczi , Miklos Szeredi , Matthew Wilcox , device-mapper development , Linux NVDIMM , linux-s390 , linux-fsdevel , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 1/5] uio: remove copy_from_iter_flushcache() and copy_mc_to_iter() Message-ID: <20211213082715.GD21462@lst.de> References: <20211209063828.18944-1-hch@lst.de> <20211209063828.18944-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Sun, Dec 12, 2021 at 06:22:20AM -0800, Dan Williams wrote: > > - * Use the 'no check' versions of copy_from_iter_flushcache() and > > - * copy_mc_to_iter() to bypass HARDENED_USERCOPY overhead. Bounds > > + * Use the 'no check' versions of _copy_from_iter_flushcache() and > > + * _copy_mc_to_iter() to bypass HARDENED_USERCOPY overhead. Bounds > > * checking, both file offset and device offset, is handled by > > * dax_iomap_actor() > > */ > > This comment change does not make sense since it is saying why pmem is > using the "_" versions. However, I assume this whole comment goes away > in a later patch. It does not go away in this series.