Re: [kvm-unit-tests PATCH 0/5] s390x: Allocation and hosting environment detection fixes

Claudio Imbrenda
2022-01-14T11:20:06Z

On Fri, 14 Jan 2022 10:02:40 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> I took some time before Christmas to write a test runner for lpar
> which automatically runs all tests and sends me the logs. It's based
> on the zhmc library to control starting and stopping of the lpar and
> works by having a menu entry for each kvm unit test.
>
> This revealed a number of test fails when the tests are run under lpar
> as there are a few differences:
> * lpars most often have a very high memory amount (upwards of 8GB)
> compared to our qemu env (256MB)
> * lpar supports diag308 subcode 2
> * lpar does not provide virtio devices
>
> The higher memory amount leads to allocations crossing the 2GB or 4GB
> border which made sclp and sigp calls fail that expect 31/32 bit
> addresses.
>

the series looks good to me; if you send me a fixed patch 3, I'll queue
this together with the other ones

> Janosch Frank (5):
> lib: s390x: vm: Add kvm and lpar vm queries
> s390x: css: Skip if we're not run by qemu
> s390x: diag308: Only test subcode 2 under QEMU
> s390x: smp: Allocate memory in DMA31 space
> s390x: firq: Fix sclp buffer allocation
>
> lib/s390x/vm.c | 39 +++++++++++++++++++++++++++++++++++++++
> lib/s390x/vm.h | 23 +++++++++++++++++++++++
> s390x/css.c | 10 +++++++++-
> s390x/diag308.c | 15 ++++++++++++++-
> s390x/firq.c | 2 +-
> s390x/smp.c | 4 ++--
> s390x/stsi.c | 21 +--------------------
> 7 files changed, 89 insertions(+), 25 deletions(-)
>