Re: [kvm-unit-tests PATCH 1/4] s390x: uv-host: Add attestation test

Claudio Imbrenda
2022-01-28T09:58:41Z

On Fri, 28 Jan 2022 10:29:42 +0100
Thomas Huth <thuth@redhat.com> wrote:

> On 28/01/2022 10.00, Janosch Frank wrote:
> > On 1/27/22 15:15, Steffen Eiden wrote:
> >> Adds an invalid command test for attestation in the uv-host.
> >>
> >> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
> >
> > Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> >
> >> ---
> >>   lib/s390x/asm/uv.h | 24 +++++++++++++++++++++++-
> >>   s390x/uv-host.c    |  3 ++-
> >>   2 files changed, 25 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
> >> index 97c90e81..38c322bf 100644
> >> --- a/lib/s390x/asm/uv.h
> >> +++ b/lib/s390x/asm/uv.h
> >> @@ -1,10 +1,11 @@
> >>   /*
> >>    * s390x Ultravisor related definitions
> >>    *
> >> - * Copyright (c) 2020 IBM Corp
> >> + * Copyright (c) 2020, 2022 IBM Corp
> >
> > I'm not sure when we actually need/want to update this.
>
> IANAL, but IIRC you can add/update the second year in the copyright
> statement if there has been a major change to the file in that year, so that
> should be fine. Not sure whether you still need the "(c)" these days, though.
>
> Thomas
>

I think the format IBM wants is:

Copyright IBM Corp. 2020, 2022