From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCF8C433F5 for ; Wed, 23 Feb 2022 15:18:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241506AbiBWPSd (ORCPT ); Wed, 23 Feb 2022 10:18:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241514AbiBWPSb (ORCPT ); Wed, 23 Feb 2022 10:18:31 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C137139698; Wed, 23 Feb 2022 07:18:03 -0800 (PST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21NDfkD3023289; Wed, 23 Feb 2022 15:18:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=7IfTCdpcvU+J9PLrfTMaQCfqrEbyRNAcKIyqyGmdRbU=; b=MGJF3CWh1ui1p39ysCPGUApJ5inxWLSvBXcYTzQS4nunsYGNf9wIMc6pGmvXIDuaT1zv 25TnqPCZbJzS91FZ33WDCP8zsAKg3fnQOTm+B+y+aTvIUrT5IXyiukGeO/LBduJj3X0W DSnel4R0u6wiLQIccTetbSPfvVxJ1p949jjbjW1wOQEytMMU5XzCbDtLL0S5DeHgSI0D fY4C9b3rB7QaM2t+DP6ZXjdj/TzxHfjnSfjCO4gYY9mLFUkdPIwOoNnPI6aSp8PpLhHk +TLstXcHfgDY2dcRlIN6zjAXkC/9ClrVVTKKJsD0puUeswAfUtKAJG7f9ekEEiW5+i2o RQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3edp1jjggf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Feb 2022 15:18:03 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 21NEIG8X005022; Wed, 23 Feb 2022 15:18:02 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 3edp1jjgex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Feb 2022 15:18:02 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 21NFCYw2009807; Wed, 23 Feb 2022 15:16:58 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma02fra.de.ibm.com with ESMTP id 3ear699ft8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Feb 2022 15:16:58 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 21NFGrtw48955870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Feb 2022 15:16:53 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7021A11C052; Wed, 23 Feb 2022 15:16:53 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 193D511C050; Wed, 23 Feb 2022 15:16:53 +0000 (GMT) Received: from p-imbrenda (unknown [9.145.2.54]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 23 Feb 2022 15:16:53 +0000 (GMT) Date: Wed, 23 Feb 2022 16:16:50 +0100 From: Claudio Imbrenda To: Nico Boehr Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, thuth@redhat.com, david@redhat.com Subject: Re: [kvm-unit-tests PATCH v3 6/8] s390x: Add more tests for STSCH Message-ID: <20220223161650.0e47ca8a@p-imbrenda> In-Reply-To: <20220223132940.2765217-7-nrb@linux.ibm.com> References: <20220223132940.2765217-1-nrb@linux.ibm.com> <20220223132940.2765217-7-nrb@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Content-Type: text/plain; charset=US-ASCII X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: z0EkWI7i-Pev9IQBdoitp03KRoyyWSwX X-Proofpoint-GUID: EpCE36hrEHMdE_uK_YKYIV0w9_LK6y5B Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-02-23_06,2022-02-23_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202230085 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Wed, 23 Feb 2022 14:29:38 +0100 Nico Boehr wrote: > css_lib extensively uses STSCH, but two more cases deserve their own > tests: > > - unaligned address for SCHIB. We check for misalignment by 1 and 2 > bytes. > - channel not operational > - bit 47 in SID not set > - bit 5 of PMCW flags. > As per the principles of operation, bit 5 of the PMCW flags shall be > ignored by msch and always stored as zero by stsch. > > Older QEMU versions require this bit to always be zero on msch, > which is why this test may fail. A fix is available in QEMU master > commit 2df59b73e086 ("s390x/css: fix PMCW invalid mask"). > > Here's the QEMU PMCW invalid mask fix: https://lists.nongnu.org/archive/html/qemu-s390x/2021-12/msg00100.html > > Signed-off-by: Nico Boehr Reviewed-by: Claudio Imbrenda > --- > s390x/css.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > diff --git a/s390x/css.c b/s390x/css.c > index a90a0cd64e2b..021eb12573c0 100644 > --- a/s390x/css.c > +++ b/s390x/css.c > @@ -496,6 +496,78 @@ static void test_ssch(void) > report_prefix_pop(); > } > > +static void test_stsch(void) > +{ > + const int align_to = 4; > + struct schib schib; > + int cc; > + > + if (!test_device_sid) { > + report_skip("No device"); > + return; > + } > + > + report_prefix_push("Unaligned"); > + for (int i = 1; i < align_to; i *= 2) { > + report_prefix_pushf("%d", i); > + > + expect_pgm_int(); > + stsch(test_device_sid, (struct schib *)(alignment_test_page + i)); > + check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); > + > + report_prefix_pop(); > + } > + report_prefix_pop(); > + > + report_prefix_push("Invalid subchannel number"); > + cc = stsch(0x0001ffff, &schib); > + report(cc == 3, "Channel not operational"); > + report_prefix_pop(); > + > + report_prefix_push("Bit 47 in SID is zero"); > + expect_pgm_int(); > + stsch(0x0000ffff, &schib); > + check_pgm_int_code(PGM_INT_CODE_OPERAND); > + report_prefix_pop(); > +} > + > +static void test_pmcw_bit5(void) > +{ > + int cc; > + uint16_t old_pmcw_flags; > + > + cc = stsch(test_device_sid, &schib); > + if (cc) { > + report_fail("stsch: sch %08x failed with cc=%d", test_device_sid, cc); > + return; > + } > + old_pmcw_flags = schib.pmcw.flags; > + > + report_prefix_push("Bit 5 set"); > + > + schib.pmcw.flags = old_pmcw_flags | BIT(15 - 5); > + cc = msch(test_device_sid, &schib); > + report(!cc, "MSCH cc == 0"); > + > + cc = stsch(test_device_sid, &schib); > + report(!cc, "STSCH cc == 0"); > + report(!(schib.pmcw.flags & BIT(15 - 5)), "STSCH PMCW Bit 5 is clear"); > + > + report_prefix_pop(); > + > + report_prefix_push("Bit 5 clear"); > + > + schib.pmcw.flags = old_pmcw_flags & ~BIT(15 - 5); > + cc = msch(test_device_sid, &schib); > + report(!cc, "MSCH cc == 0"); > + > + cc = stsch(test_device_sid, &schib); > + report(!cc, "STSCH cc == 0"); > + report(!(schib.pmcw.flags & BIT(15 - 5)), "STSCH PMCW Bit 5 is clear"); > + > + report_prefix_pop(); > +} > + > static struct { > const char *name; > void (*func)(void); > @@ -511,6 +583,8 @@ static struct { > { "msch", test_msch }, > { "stcrw", test_stcrw }, > { "ssch", test_ssch }, > + { "stsch", test_stsch }, > + { "pmcw bit 5 ignored", test_pmcw_bit5 }, > { NULL, NULL } > }; >