Re: [kvm-unit-tests PATCH 5/8] s390x: pv-diags: Cleanup includes

Janosch Frank
2022-04-06T17:26:33Z

On 4/6/22 08:50, Thomas Huth wrote:
> On 05/04/2022 09.52, Janosch Frank wrote:
>> This file has way too much includes. Time to remove some.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> s390x/pv-diags.c | 17 ++---------------
>> 1 file changed, 2 insertions(+), 15 deletions(-)
>>
>> diff --git a/s390x/pv-diags.c b/s390x/pv-diags.c
>> index 6899b859..9ced68c7 100644
>> --- a/s390x/pv-diags.c
>> +++ b/s390x/pv-diags.c
>> @@ -8,23 +8,10 @@
>> * Janosch Frank <frankja@linux.ibm.com>
>> */
>> #include <libcflat.h>
>> -#include <asm/asm-offsets.h>
>> -#include <asm-generic/barrier.h>
>> -#include <asm/interrupt.h>
>> -#include <asm/pgtable.h>
>> -#include <mmu.h>
>> -#include <asm/page.h>
>> -#include <asm/facility.h>
>> -#include <asm/mem.h>
>> -#include <asm/sigp.h>
>> -#include <smp.h>
>> -#include <alloc_page.h>
>> -#include <vmalloc.h>
>> -#include <sclp.h>
>> #include <snippet.h>
>> #include <sie.h>
>> -#include <uv.h>
>> -#include <asm/uv.h>
>> +#include <sclp.h>
>> +#include <asm/facility.h>
>
> Wow, how did we end up with that huge list? Copy-n-paste from other files?
>

Yes, and lots of work to get it working in the first place which pulled
in headers which weren't removed later once they were unused.

That's one of the reasons why I suggested the templates to you :-)

> Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks