Re: [kvm-unit-tests PATCH 6/8] s390x: css: Cleanup includes

Claudio Imbrenda
2022-04-05T11:47:49Z

On Tue, 5 Apr 2022 07:52:23 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Most includes were related to allocation but that's done in the io
> allocation library so having them in the test doesn't make sense.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
> s390x/css.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/s390x/css.c b/s390x/css.c
> index 52d35f49..9cfcfad4 100644
> --- a/s390x/css.c
> +++ b/s390x/css.c
> @@ -9,17 +9,14 @@
> */
>
> #include <libcflat.h>
> -#include <alloc_phys.h>
> -#include <asm/page.h>
> -#include <string.h>
> #include <interrupt.h>
> -#include <asm/arch_def.h>
> -#include <alloc_page.h>
> #include <hardware.h>
>
> +#include <asm/arch_def.h>
> +#include <asm/page.h>
> +
> #include <malloc_io.h>
> #include <css.h>
> -#include <asm/barrier.h>
>
> #define DEFAULT_CU_TYPE 0x3832 /* virtio-ccw */
> static unsigned long cu_type = DEFAULT_CU_TYPE;