From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF861C433F5 for ; Wed, 11 May 2022 11:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231186AbiEKLO2 (ORCPT ); Wed, 11 May 2022 07:14:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbiEKLO0 (ORCPT ); Wed, 11 May 2022 07:14:26 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76021201F05; Wed, 11 May 2022 04:14:24 -0700 (PDT) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24BALOKC023407; Wed, 11 May 2022 11:14:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=9vopTSNSfmIct9qze/EmlEQKTb4H10/Yw8EtCJnjRTU=; b=kMUAxoSfsneEn/qkZys/Pk21R7kC9ItHadaCMMtEWoK+CoIZ+0347YU8l05NNKgkk0U0 cHYMTlGX6G9wkKJYp7V1wqN3lHg4Vpxqmuta+ozGNiTE8tVgWJPB/jQv7EeJTpzGJ5IN jIe7Df7EcO7eb2ZALX+AaFg5q+VP/NuPwss4WlREHvqXSU0KxGcVGqtWkzr/nIkDxrvl 8VS4bgeJVJIMYM+yf3CNbwuT53+LGjuFbEkcmqaVPwCCAZ8h4bQr8hOfWBciR2QI+FiQ MEqZzYWjgjuyKsQDgOF3C5Yc6cPAZSAnqhPsF1StyHl7HebZoKQ/eirWrqkyjjOCMlTp 2g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g0baerus0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 May 2022 11:14:23 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24BAuYg5017711; Wed, 11 May 2022 11:14:23 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g0baerurm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 May 2022 11:14:23 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24BBDFtb015039; Wed, 11 May 2022 11:14:21 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06ams.nl.ibm.com with ESMTP id 3fyrkk18b6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 May 2022 11:14:21 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24BBEIw148038340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 May 2022 11:14:18 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0424B4C046; Wed, 11 May 2022 11:14:18 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C5D754C040; Wed, 11 May 2022 11:14:17 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.40]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 11 May 2022 11:14:17 +0000 (GMT) Date: Wed, 11 May 2022 13:14:14 +0200 From: Claudio Imbrenda To: Nico Boehr Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, thuth@redhat.com Subject: Re: [kvm-unit-tests PATCH v2 2/2] s390x: add cmm migration test Message-ID: <20220511131414.63edc473@p-imbrenda> In-Reply-To: <20220511085652.823371-3-nrb@linux.ibm.com> References: <20220511085652.823371-1-nrb@linux.ibm.com> <20220511085652.823371-3-nrb@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: K0wyynlIqBzoJCas6zX4IR_wRoqpGqOQ X-Proofpoint-GUID: qQ3rJcGNC3ZBVbGgoIHEfLDi_9x3ZaBC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-11_03,2022-05-11_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205110051 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Wed, 11 May 2022 10:56:52 +0200 Nico Boehr wrote: > When a VM is migrated, we expect the page states to be preserved. Add a test > which checks for that. > > Signed-off-by: Nico Boehr > --- > s390x/Makefile | 1 + > s390x/migration-cmm.c | 78 +++++++++++++++++++++++++++++++++++++++++++ > s390x/unittests.cfg | 4 +++ > 3 files changed, 83 insertions(+) > create mode 100644 s390x/migration-cmm.c > > diff --git a/s390x/Makefile b/s390x/Makefile > index a8e04aa6fe4d..1877c8a6e86e 100644 > --- a/s390x/Makefile > +++ b/s390x/Makefile > @@ -32,6 +32,7 @@ tests += $(TEST_DIR)/epsw.elf > tests += $(TEST_DIR)/adtl-status.elf > tests += $(TEST_DIR)/migration.elf > tests += $(TEST_DIR)/pv-attest.elf > +tests += $(TEST_DIR)/migration-cmm.elf > > pv-tests += $(TEST_DIR)/pv-diags.elf > > diff --git a/s390x/migration-cmm.c b/s390x/migration-cmm.c > new file mode 100644 > index 000000000000..97bba138bcf9 > --- /dev/null > +++ b/s390x/migration-cmm.c > @@ -0,0 +1,78 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * CMM migration tests (ESSA) > + * > + * Copyright IBM Corp. 2022 > + * > + * Authors: > + * Nico Boehr > + */ > + > +#include > +#include do we actually need this include? if not, remove it, then you can add: Reviewed-by: Claudio Imbrenda > +#include > +#include > +#include > +#include > + > +#define NUM_PAGES 128 > +static uint8_t pagebuf[NUM_PAGES][PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); > + > +static void test_migration(void) > +{ > + int i, state_mask, actual_state; > + /* > + * Maps ESSA actions to states the page is allowed to be in after the > + * respective action was executed. > + */ > + int allowed_essa_state_masks[4] = { > + BIT(ESSA_USAGE_STABLE), /* ESSA_SET_STABLE */ > + BIT(ESSA_USAGE_UNUSED), /* ESSA_SET_UNUSED */ > + BIT(ESSA_USAGE_VOLATILE), /* ESSA_SET_VOLATILE */ > + BIT(ESSA_USAGE_VOLATILE) | BIT(ESSA_USAGE_POT_VOLATILE) /* ESSA_SET_POT_VOLATILE */ > + }; > + > + assert(NUM_PAGES % 4 == 0); > + for (i = 0; i < NUM_PAGES; i += 4) { > + essa(ESSA_SET_STABLE, (unsigned long)pagebuf[i]); > + essa(ESSA_SET_UNUSED, (unsigned long)pagebuf[i + 1]); > + essa(ESSA_SET_VOLATILE, (unsigned long)pagebuf[i + 2]); > + essa(ESSA_SET_POT_VOLATILE, (unsigned long)pagebuf[i + 3]); > + } > + > + puts("Please migrate me, then press return\n"); > + (void)getchar(); > + > + for (i = 0; i < NUM_PAGES; i++) { > + actual_state = essa(ESSA_GET_STATE, (unsigned long)pagebuf[i]); > + /* extract the usage state in bits 60 and 61 */ > + actual_state = (actual_state >> 2) & 0x3; > + state_mask = allowed_essa_state_masks[i % ARRAY_SIZE(allowed_essa_state_masks)]; > + report(BIT(actual_state) & state_mask, "page %d state: expected_mask=0x%x actual_mask=0x%lx", i, state_mask, BIT(actual_state)); > + } > +} > + > +int main(void) > +{ > + bool has_essa = check_essa_available(); > + > + report_prefix_push("cmm-migration"); > + if (!has_essa) { > + report_skip("ESSA is not available"); > + > + /* > + * If we just exit and don't ask migrate_cmd to migrate us, it > + * will just hang forever. Hence, also ask for migration when we > + * skip this test alltogether. > + */ > + puts("Please migrate me, then press return\n"); > + (void)getchar(); > + > + goto done; > + } > + > + test_migration(); > +done: > + report_prefix_pop(); > + return report_summary(); > +} > diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg > index b456b2881448..9b97d0471bcf 100644 > --- a/s390x/unittests.cfg > +++ b/s390x/unittests.cfg > @@ -176,3 +176,7 @@ extra_params = -cpu qemu,gs=off,vx=off > file = migration.elf > groups = migration > smp = 2 > + > +[migration-cmm] > +file = migration-cmm.elf > +groups = migration