Re: [PATCH 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

Jason Gunthorpe
2022-05-18T11:58:59Z

On Wed, May 18, 2022 at 12:39:41AM -0700, Christoph Hellwig wrote:
> > if (device->ops->flags & VFIO_DEVICE_NEEDS_KVM)
> > {
>
> Nit: this is not the normal brace placement.
>
> But what is you diff against anyway? The one Matthew sent did away
> with the VFIO_DEVICE_NEEDS_KVM flags, which does the wrong thing for
> zpci, so it can't be that..

Against what I sent before, I did this before Matthew sent his

> Also if we want to do major code movement, it really needs to go into
> a separate patch or patches, as the combinations of all these moves
> with actual code changes is almost unreadable.

Sure, just checking how things could look at this point

Matthew's version first followed by the code motion is probably a good
approach.

Jason