From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A06FEC43334 for ; Fri, 24 Jun 2022 06:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230513AbiFXG7z (ORCPT ); Fri, 24 Jun 2022 02:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbiFXG7y (ORCPT ); Fri, 24 Jun 2022 02:59:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8EB9168C72 for ; Thu, 23 Jun 2022 23:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656053992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+FWCkGupGlsZhDvUF+chx88Z13TTRnc4OkTdsQ7elnE=; b=i9nOA8tidr8vr+EgGLUER/bvbW4tIdNQxluM98Es2W3gAXa4Pf94kxFnFgK7j50tJU6rk7 X7LuJDBSH2RkKDhCqE4SX1k7Khxm3+jDLIJLeatiqoSvDjaavUlgChSJc9Pexr/r/sgHtS VMsSA8hdrDXCzCTB7vB8d0No4TR2gLM= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-wLK-0KO2NHWLwG72HfUggw-1; Fri, 24 Jun 2022 02:59:49 -0400 X-MC-Unique: wLK-0KO2NHWLwG72HfUggw-1 Received: by mail-ed1-f70.google.com with SMTP id x8-20020a056402414800b0042d8498f50aso1184584eda.23 for ; Thu, 23 Jun 2022 23:59:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+FWCkGupGlsZhDvUF+chx88Z13TTRnc4OkTdsQ7elnE=; b=TdKvSNiRy40B7xlFv/34hpS94qpymfDZLjZ/pNIpGj6MBtHUNbRIoJ157asgmR+6v7 o04deEiZFvaIXY5xCYbVoZzXNxaZxdyhM4kD2VtVM/9aytANutX8dQQ1whOSB1oaDZbU cPwOuQxwurXaH5pfJLQvwcWcaFxyZmAkuMcPV6V8ZdtkSdfnn7kgip0mE6/A4HgsHiw8 dIHzmq05Dk34ADaX2lc4syypkgbAeYIHp5W2gIuHUw47I7OAFpp1yDLhTD0JqSMdRyUV Xwsd88y/ZoZb/a2a2qUvfOaglvxsOVa78OzbUS0cOvZM5L+tPFo1fKfeGakbQ6/ih2I8 Tysg== X-Gm-Message-State: AJIora/iGTqXNbLHC3Rif/bOr4UMzzPQs0/pJBpUY2nCfahfxZbDmM2R wGl8fbn8KeB8ffSGinhuqI+U07RQUSzw2zpVzCkXT5AwFSMewKNQckDdO4SJUI9gAeAbaPUSmaS V1/jJ1AclMBsMIpa3lLA17A== X-Received: by 2002:a17:906:dc8f:b0:725:28d1:422d with SMTP id cs15-20020a170906dc8f00b0072528d1422dmr6755855ejc.131.1656053987936; Thu, 23 Jun 2022 23:59:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1te/UstSdzxfRYfD6/tSqZXRF+jwCBe0/TwLXdOIJy4AlZcp3dqgfDv8QmtvsXyUBUV1p/nQw== X-Received: by 2002:a17:906:dc8f:b0:725:28d1:422d with SMTP id cs15-20020a170906dc8f00b0072528d1422dmr6755835ejc.131.1656053987674; Thu, 23 Jun 2022 23:59:47 -0700 (PDT) Received: from redhat.com ([2.55.188.216]) by smtp.gmail.com with ESMTPSA id ec35-20020a0564020d6300b004316f94ec4esm1262273edb.66.2022.06.23.23.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 23:59:46 -0700 (PDT) Date: Fri, 24 Jun 2022 02:59:39 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: virtualization@lists.linux-foundation.org, Richard Weinberger , Anton Ivanov , Johannes Berg , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data Message-ID: <20220624025817-mutt-send-email-mst@kernel.org> References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. What exactly is meant by not breaking uABI? Users are supposed to be prepared for struct size to change ... no? > Since I want to add queue_reset after queue_notify_data, I submitted > this patch first. > > Signed-off-by: Xuan Zhuo > Acked-by: Jason Wang > --- > include/uapi/linux/virtio_pci.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > index 3a86f36d7e3d..22bec9bd0dfc 100644 > --- a/include/uapi/linux/virtio_pci.h > +++ b/include/uapi/linux/virtio_pci.h > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > __le32 queue_used_hi; /* read-write */ > }; > > +struct virtio_pci_common_cfg_notify { > + struct virtio_pci_common_cfg cfg; > + > + __le16 queue_notify_data; /* read-write */ > + __le16 padding; > +}; > + > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > struct virtio_pci_cfg_cap { > struct virtio_pci_cap cap; > -- > 2.31.0