Re: [PATCH 04/15] vfio/mdev: embedd struct mdev_parent in the parent data structure

Christoph Hellwig
2022-07-07T13:40:25Z

On Thu, Jul 07, 2022 at 09:22:21AM +0200, Vineeth Vijayan wrote:
> Thank you Eric for pointing it out. You are right. I think the struct
> subchannel is obviously the wrong place.
> Also, in this case, the mdev_parent should be in one of the vfio-ccw
> io-subchannel structure, which as you mentioned should be in vfio-ccw*.

It is where the parent dev is embedded into, so it sticks to the
spirit of the old code. I'm totally fine with you guys moving it
to another structure of your choice, but for making progress on this
series it should be good enough.