Re: [PATCH net-next 01/10] net/smc: remove locks smc_client_lgr_pending and smc_server_lgr_pending

kernel test robot
2022-08-11T03:41:23Z

Hi Wythe",

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/D-Wythe/net-smc-optimize-the-parallelism-of-SMC-R-connections/20220811-014942
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f86d1fbbe7858884d6754534a0afbb74fc30bc26
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220811/202208111145.LdpP76au-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2c1c2e644fb8dbce9b8a004e604792340cbfccb8
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review D-Wythe/net-smc-optimize-the-parallelism-of-SMC-R-connections/20220811-014942
git checkout 2c1c2e644fb8dbce9b8a004e604792340cbfccb8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/smc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/smc/smc_core.c:95:30: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Wparentheses]
+ (lnkc->role == SMC_SERV) ? 0 : lnkc->clcqpn;
~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
net/smc/smc_core.c:95:30: note: place parentheses around the '+' expression to silence this warning
+ (lnkc->role == SMC_SERV) ? 0 : lnkc->clcqpn;
^
)
net/smc/smc_core.c:95:30: note: place parentheses around the '?:' expression to evaluate it first
+ (lnkc->role == SMC_SERV) ? 0 : lnkc->clcqpn;
^
( )
net/smc/smc_core.c:104:29: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Wparentheses]
+ (key->role == SMC_SERV) ? 0 : key->clcqpn;
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
net/smc/smc_core.c:104:29: note: place parentheses around the '+' expression to silence this warning
+ (key->role == SMC_SERV) ? 0 : key->clcqpn;
^
)
net/smc/smc_core.c:104:29: note: place parentheses around the '?:' expression to evaluate it first
+ (key->role == SMC_SERV) ? 0 : key->clcqpn;
^
( )
2 warnings generated.

vim +95 net/smc/smc_core.c

88
89 /* SMC-R lnk cluster hash func */
90 static u32 smcr_lnk_cluster_hashfn(const void *data, u32 len, u32 seed)
91 {
92 const struct smc_lnk_cluster *lnkc = data;
93
94 return jhash2((u32 *)lnkc->peer_systemid, SMC_SYSTEMID_LEN / sizeof(u32), seed)
> 95 + (lnkc->role == SMC_SERV) ? 0 : lnkc->clcqpn;
96 }
97

--
0-DAY CI Kernel Test Service