From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389F5FA3743 for ; Mon, 31 Oct 2022 08:06:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbiJaIGL (ORCPT ); Mon, 31 Oct 2022 04:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiJaIGK (ORCPT ); Mon, 31 Oct 2022 04:06:10 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65A4019F for ; Mon, 31 Oct 2022 01:06:07 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id q9so27484329ejd.0 for ; Mon, 31 Oct 2022 01:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=poxA0LEev9jPrhZnkwyY7vsWe/HDoG5TgR6taboptUU=; b=LYy0CICIyprTOFQXJbmxldQgszdggru36ppt8BlYlS/6Fadz4lG7+PvpBInXK3sEwl 9c19coxXN6zfPF621QDiLFySz9+w3De89yPYhIqd1pl1g1LL2OTgeS0IT7F60LNAXCBj TF4jCAkyzHckAHw+4NbUXCJlkXC8jqinNwGBAo650tUVkm4qOCdpQOyA6+CxyIo6oVJI KHTpD5kEOyKveHPx/t7FAd8yS3EE8MPg+seA2KF22Fmhl2l8FspTrr8RgWX++cf2eZMF xm3SjqbAjsK1sVWszFcL2x0alWobxfqRnsQgl+JbUXYc2ZUSVa7+sfBfsb+bIQSHYlqq KjfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=poxA0LEev9jPrhZnkwyY7vsWe/HDoG5TgR6taboptUU=; b=wm7CacJ/IfM8QG+BQdkv9+DEcAt+2iBDiqabYYGMwUF7I/3r0dyIJezB7gL7oMKFv1 z21gAfEdXJdNf+cug3T+8WopDFIhY+jvU57wY2HOqwDf+c+fqARj5GznN0MDqHV6S7P7 Rtb2tUuPtiaNt2B9JlqROykoVKT+bmG1THcjeuQoSf043yjtGcaN4Je+QApP9ask6snU aIQIrGdAaROdRbMG8J3bB/bgge43skK02kM3Ju78YJc48SmOBXvWBh3I7KuKFGjJa6rZ hpOJhkKy82Me99TR9vLR1+2Kj6X8Ur+mVRXspPGoHIdiCS8KYzAjaiT0FKkw3f+6s/Mc XO0A== X-Gm-Message-State: ACrzQf2fvlDJPjNt/Mxw0fSfiWUE4JpjgyyvWbZo7+PRO5Ow+slDnU3+ s/nQI4S+7ef1g1gPkam/T0yk4Q== X-Google-Smtp-Source: AMsMyM5muTvUIOECduCaxj0EnA1GyAIhvxzQvG2kLFyGrfnTCKJuYOT5siPGSm+xWiTGjY/PqNGVtg== X-Received: by 2002:a17:907:80b:b0:77a:86a1:db52 with SMTP id wv11-20020a170907080b00b0077a86a1db52mr11721653ejb.294.1667203565981; Mon, 31 Oct 2022 01:06:05 -0700 (PDT) Received: from localhost (cst2-173-61.cust.vodafone.cz. [31.30.173.61]) by smtp.gmail.com with ESMTPSA id kz4-20020a17090777c400b0077b523d309asm2663665ejc.185.2022.10.31.01.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 01:06:05 -0700 (PDT) Date: Mon, 31 Oct 2022 09:06:04 +0100 From: Andrew Jones To: Borislav Petkov Cc: Yury Norov , x86@kernel.org, linux-riscv , Linux Kernel Mailing List , Thomas Gleixner , Ingo Molnar , Dave Hansen , Palmer Dabbelt , Paul Walmsley , Albert Ou , Jonas Bonn , Stefan Kristiansson , Stafford Horne , openrisc@lists.librecores.org, Michael Ellerman , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , linux-s390@vger.kernel.org Subject: Re: [PATCH v3 2/2] x86: Fix /proc/cpuinfo cpumask warning Message-ID: <20221031080604.6xei6c4e3ckhsvmy@kamzik> References: <20221014155845.1986223-1-ajones@ventanamicro.com> <20221014155845.1986223-3-ajones@ventanamicro.com> <20221028074828.b66uuqqfbrnjdtab@kamzik> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Fri, Oct 28, 2022 at 06:06:41PM +0200, Borislav Petkov wrote: > On Fri, Oct 28, 2022 at 10:13:28AM -0500, Yury Norov wrote: > > Because it's related to bitmap API usage and has been revealed after > > some work in bitmaps. > > So first of all, that "fix" needs to explain what exactly it is fixing. > Not "it fixes this and that warning" but why the input arg to > cpumask_next() cannot be nr_cpu_ids because... yadda yadda... Hi Boris, I didn't realize you were still looking for improvements to the commit message for this patch. I could add something like, The valid cpumask range is [0, nr_cpu_ids) and cpumask_next() always returns a CPU ID greater than its input, which results in its input range being [-1, nr_cpu_ids - 1). Ensure showing CPU info avoids triggering error conditions in cpumask_next() by stopping its loop over CPUs when its input would be invalid. Thanks, drew > > > And because nobody else cares. > > Why do you assume that? > > > If you're willing to move it yourself please go ahead. > > If it fixes a real issue, we are taking it. And pls note that x86 > patches go through the tip tree. > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette