From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57AC8FA3741 for ; Mon, 31 Oct 2022 22:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbiJaWy0 (ORCPT ); Mon, 31 Oct 2022 18:54:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbiJaWyS (ORCPT ); Mon, 31 Oct 2022 18:54:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A2962DC2 for ; Mon, 31 Oct 2022 15:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667256798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bHpC1zf1qV1jmlc1wntYS1OKLTiiLa4Edpg3f0kbUyY=; b=Udrgb+4anK2Waf5x646xCIt+siPX86RcZjnUkEfDrP9uMHRvvnQVtEaWG8Mx3lnpfAhfYQ DpKYglVHmONERP/Y+0h8O3n0XguJ8wox+gCIQhol0GJt1X9fXDeNMWPRUrgmBo6IwmYXmj KWHBlbOWnuW4SB/U0nohDT+CGxa1+pI= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-594-pq9WRvNGN4iCFZ1V79PLEw-1; Mon, 31 Oct 2022 18:53:14 -0400 X-MC-Unique: pq9WRvNGN4iCFZ1V79PLEw-1 Received: by mail-io1-f69.google.com with SMTP id bf14-20020a056602368e00b006ce86e80414so2994489iob.7 for ; Mon, 31 Oct 2022 15:53:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bHpC1zf1qV1jmlc1wntYS1OKLTiiLa4Edpg3f0kbUyY=; b=TthZCL4TawpM+D6dJpjQINC8fhzYECIt4T+4AV+/jhkFmAiDs9JFbshmwBidUpu6q+ 3prE9WEiGOk0yqurBgPWgomHrEs3UVcnbjat1uFpgLuO0g6pEDFDbDi5FRpOwfg/5vO2 MI4cVViOIL9eptWCnpWMqOOzzcUzo0gu7dGPthv4KNZUIxq84egwxZtGEKKc4hZI8Cz8 JARVYzpvLBaYQXL4krqLLMf8VyuIGN9URCPux+i7N0uWRWt5uY5oLcybL/GjkGN/OtKV Lrmjh8GVreaiyaNSmcjHmtc4XdRN8+577mqMoVATd8BjpC9vRi2t6nlwQ+19KaHzBWvp ypJQ== X-Gm-Message-State: ACrzQf0ntyTNQpJxXucrg75tjvSLChlEzN3PPMIm3HF13JT8Lc0CyY63 JmDGde4TtAAthzKe+V2YZd+1bam4penhb2Xump6BxTj+X9A4MapOjiho5eyIfSjGLHeo8UiOmHC X83YDzB7Jmedmj0W+bMF8qA== X-Received: by 2002:a05:6e02:180c:b0:2fc:4018:9440 with SMTP id a12-20020a056e02180c00b002fc40189440mr7991803ilv.225.1667256793686; Mon, 31 Oct 2022 15:53:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7liCEme2wsc4XzJa+HajVmv1KVpsxVcMQII15KI4qdQbhYdKRKQskOMruD/YfHk1W7Cq0evQ== X-Received: by 2002:a05:6e02:180c:b0:2fc:4018:9440 with SMTP id a12-20020a056e02180c00b002fc40189440mr7991769ilv.225.1667256793463; Mon, 31 Oct 2022 15:53:13 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id g15-20020a02850f000000b00372bbd04b75sm3200984jai.87.2022.10.31.15.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 15:53:12 -0700 (PDT) Date: Mon, 31 Oct 2022 16:53:11 -0600 From: Alex Williamson To: Jason Gunthorpe Cc: Alexander Gordeev , David Airlie , Tony Krowiak , Christian Borntraeger , Cornelia Huck , Daniel Vetter , Diana Craciun , dri-devel@lists.freedesktop.org, Eric Auger , Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, iommu@lists.linux.dev, Jani Nikula , Jason Herne , Joonas Lahtinen , Joerg Roedel , Kevin Tian , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Longfang Liu , Matthew Rosato , Peter Oberparleiter , Halil Pasic , Robin Murphy , Rodrigo Vivi , Shameer Kolothum , Sven Schnelle , Tvrtko Ursulin , Vineeth Vijayan , Will Deacon , Yishai Hadas , Zhenyu Wang , Zhi Wang , Lu Baolu , Nicolin Chen , Yi Liu Subject: Re: [PATCH 10/10] iommufd: Allow iommufd to supply /dev/vfio/vfio Message-ID: <20221031165311.0698e1ea.alex.williamson@redhat.com> In-Reply-To: References: <0-v1-4991695894d8+211-vfio_iommufd_jgg@nvidia.com> <10-v1-4991695894d8+211-vfio_iommufd_jgg@nvidia.com> <20221026153133.44dc05c8.alex.williamson@redhat.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Fri, 28 Oct 2022 15:44:36 -0300 Jason Gunthorpe wrote: > On Wed, Oct 26, 2022 at 03:31:33PM -0600, Alex Williamson wrote: > > On Tue, 25 Oct 2022 15:50:45 -0300 > > Jason Gunthorpe wrote: > > > > > If the VFIO container is compiled out, give a kconfig option for iommufd > > > to provide the miscdev node with the same name and permissions as vfio > > > uses. > > > > > > The compatibility node supports the same ioctls as VFIO and automatically > > > enables the VFIO compatible pinned page accounting mode. > > > > I think I'd like to see some sort of breadcrumb when /dev/vfio/vfio is > > provided by something other than the vfio container code. If we intend > > to include this before P2P is resolved, that breadcrumb > > I don't belive I can get P2P done soon enough. I plan to do it after > this is merged. Right now these two series are taking all my time. > > > (dmesg I'm guessing) might also list any known limitations of the > > compatibility to save time with debugging. Thanks, > > Yes, that makes sense. > > Do you want a dmesg at module load time, on every open, or a sysfs > something? What seems like it would make it into a bug report? I think dmesg at module load time should probably be ok, every open seems like harassment and sysfs would require updated support in various bug reporting tools. Users are often terrible about reporting full dmesg in bugs, but they do often filter it for "IOMMU" or "VFIO", so keep that in mind when crafting the log message. Thanks, Alex