From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CBAEC43217 for ; Wed, 2 Nov 2022 20:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbiKBUBd (ORCPT ); Wed, 2 Nov 2022 16:01:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230396AbiKBUB3 (ORCPT ); Wed, 2 Nov 2022 16:01:29 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC2413D for ; Wed, 2 Nov 2022 13:01:28 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id o7so14059952pjj.1 for ; Wed, 02 Nov 2022 13:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=crDMk0R12pE4R+rJIlvy8EsGZM7TBfRAPYKWnpWAGHY=; b=UK9/AZo0Gy9FmiPW3MCdfsBkfo+eIrkJ8azyv3CjPHoN4MhEkiNCR8PNH7yhFsYAOV OcpJgIYxLNKdG/2WV1Ir7KHesKgC3PaVShkuvcivzT1/xw5yHoEnTL+CL4JhdOo7Cq6/ kZ7Q7PuO5Kq6Dkv2HcO0D8R73xSRLPR7rqXcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=crDMk0R12pE4R+rJIlvy8EsGZM7TBfRAPYKWnpWAGHY=; b=xcJC2Mf7xvg1cXtTHbxDF+Av/wsEW/KPH8f2Txm8rKo2PRti+SarIOcyeUWmHuVPie D1E3/Q0mrof0NEcuMtWqHsRIYHsu+IdFVZ1ecQFT6oWtxSg2S98FoWSpCvJz7kwy7H6H sgKq17Oh0YHCXLO+OZ9wQNvJUCtNOSB0mVNivnUHykWzs+Vi2w2WeJp0/MCdvqbyXE4Z kPFBtEQL3Tv1RiRjANZXh2cs57+HxtFu8A3S9tdJFOfwpw/Datwqn6GubU7pOQXQDNU5 IUabccAUk3WV447LxIG8oCuPtYWXvPKt1AF063ld3s6Bmw0Xpxg8DSIn6xTpVeRsnVS1 Gi4Q== X-Gm-Message-State: ACrzQf3V0zYFPiByswqwFUDSlfonbbSuBixnjbgEtW60jeIeSqGPk8ti bBIPCu5lnQU7xGpTxnb+SSPSbvROvwq5fw== X-Google-Smtp-Source: AMsMyM6jJViHjLqCoTS++I8Qer6oLGbkwZ5YrvtcOzrUTmAZhCWRZ2VARz0FuIZVfUtOhdEVS0FtHA== X-Received: by 2002:a17:903:41ca:b0:186:a68e:c06d with SMTP id u10-20020a17090341ca00b00186a68ec06dmr25774406ple.61.1667419287620; Wed, 02 Nov 2022 13:01:27 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z184-20020a6233c1000000b0056c47a5c34dsm8825142pfz.122.2022.11.02.13.01.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 13:01:27 -0700 (PDT) Date: Wed, 2 Nov 2022 13:01:26 -0700 From: Kees Cook To: Heiko Carstens , Sami Tolvanen Cc: Nathan Chancellor , Alexandra Winter , Wenjia Zhang , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org, netdev@vger.kernel.org, Nick Desaulniers , Tom Rix , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: Re: [PATCH 1/3] s390/ctcm: Fix return type of ctc{mp,}m_tx() Message-ID: <202211021259.9169F5CBE@keescook> References: <20221102163252.49175-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Wed, Nov 02, 2022 at 08:48:42PM +0100, Heiko Carstens wrote: > On Wed, Nov 02, 2022 at 09:32:50AM -0700, Nathan Chancellor wrote: > > should s390 select ARCH_SUPPORTS_CFI_CLANG in the future. > > Yes, s390 should select that :) > > But, is there any switch or option I need to set when compiling clang, > so it knows about the kcfi sanitizer? > > I get: > clang-16: error: unsupported option '-fsanitize=kcfi' for target 's390x-ibm-linux' > > > clang --version > clang version 16.0.0 (https://github.com/llvm/llvm-project.git e02110e2ab4dd71b276e887483f0e6e286d243ed) You'll need the "generic arch support": https://reviews.llvm.org/D135411 which is _almost_ landed. Testing would be welcome, for sure! Sami, do you have any notes on what common things were needed to get arm64 and x86_64 booting under kCFI? My only oh-so-helpful notes are "keep CFI away from early boot code". :P -- Kees Cook