Re: [kvm-unit-tests PATCH 2/5] s390x: snippets: Fix SET_PSW_NEW_ADDR macro

Claudio Imbrenda
2022-11-23T13:29:15Z

On Wed, 23 Nov 2022 08:46:53 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Let's store the psw mask instead of the address of the location where we
> should load the mask from.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
> s390x/snippets/asm/macros.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/snippets/asm/macros.S b/s390x/snippets/asm/macros.S
> index 667fb6dc..09d7f5be 100644
> --- a/s390x/snippets/asm/macros.S
> +++ b/s390x/snippets/asm/macros.S
> @@ -18,7 +18,7 @@
> */
> .macro SET_PSW_NEW_ADDR reg, psw_new_addr, addr_psw
> larl \reg, psw_mask_64
> -stg \reg, \addr_psw
> +mvc \addr_psw(8,%r0), 0(\reg)
> larl \reg, \psw_new_addr
> stg \reg, \addr_psw + 8
> .endm